From 2d3f4bf73cdb878c0fee25b962b6a80113d5d80e Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Tue, 1 Dec 2015 14:22:40 +0000 Subject: [PATCH] re PR ada/68590 (FAIL: gnat.dg/loop_optimization19.adb scan-tree-dump-not optimized "Index_Check") 2015-12-01 Richard Biener PR middle-end/68590 * genmatch.c (struct capture_info): Add match_use_count. (capture_info::walk_match): Increment match_use_count. (dt_simplify::gen_1): For GENERIC, only wrap multi-use replacements in a save_expr if they occur more often than in the original expression. From-SVN: r231110 --- gcc/ChangeLog | 9 +++++++++ gcc/genmatch.c | 13 +++++++++---- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index f908fe6542a..79d8d92700b 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,12 @@ +2015-12-01 Richard Biener + + PR middle-end/68590 + * genmatch.c (struct capture_info): Add match_use_count. + (capture_info::walk_match): Increment match_use_count. + (dt_simplify::gen_1): For GENERIC, only wrap multi-use + replacements in a save_expr if they occur more often than + in the original expression. + 2015-12-01 Richard Biener PR ipa/68470 diff --git a/gcc/genmatch.c b/gcc/genmatch.c index 67d1c66a61f..16a4f35a1c3 100644 --- a/gcc/genmatch.c +++ b/gcc/genmatch.c @@ -1851,7 +1851,8 @@ struct capture_info bool force_single_use; bool cond_expr_cond_p; unsigned long toplevel_msk; - int result_use_count; + unsigned match_use_count; + unsigned result_use_count; unsigned same_as; capture *c; }; @@ -1901,6 +1902,7 @@ capture_info::walk_match (operand *o, unsigned toplevel_arg, if (capture *c = dyn_cast (o)) { unsigned where = c->where; + info[where].match_use_count++; info[where].toplevel_msk |= 1 << toplevel_arg; info[where].force_no_side_effects_p |= conditional_p; info[where].cond_expr_cond_p |= cond_expr_cond_p; @@ -3106,13 +3108,16 @@ dt_simplify::gen_1 (FILE *f, int indent, bool gimple, operand *result) else if (is_a (opr)) is_predicate = true; /* Search for captures used multiple times in the result expression - and dependent on TREE_SIDE_EFFECTS emit a SAVE_EXPR. */ + and wrap them in a SAVE_EXPR. Allow as many uses as in the + original expression. */ if (!is_predicate) for (int i = 0; i < s->capture_max + 1; ++i) { - if (cinfo.info[i].same_as != (unsigned)i) + if (cinfo.info[i].same_as != (unsigned)i + || cinfo.info[i].cse_p) continue; - if (cinfo.info[i].result_use_count > 1) + if (cinfo.info[i].result_use_count + > cinfo.info[i].match_use_count) fprintf_indent (f, indent, "captures[%d] = save_expr (captures[%d]);\n", i, i); -- 2.30.2