From 2d6385715da3368597671046368ff4fe11c1ca8e Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Fri, 19 Jun 2020 16:57:41 +1000 Subject: [PATCH] llvmpipe: blend has effects even if no colorbuffers. ARB_framebuffer_no_attachments + multisampling means blend can have an effect even outside of colorbufs Fixes: dEQP-VK.pipeline.multisample.alpha_to_coverage_no_color_attachment.samples_4.alpha_opaque Reviewed-by: Roland Scheidegger Part-of: --- src/gallium/drivers/llvmpipe/lp_state_fs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c b/src/gallium/drivers/llvmpipe/lp_state_fs.c index efb6bee2511..804ed9214c6 100644 --- a/src/gallium/drivers/llvmpipe/lp_state_fs.c +++ b/src/gallium/drivers/llvmpipe/lp_state_fs.c @@ -3987,9 +3987,7 @@ make_variant_key(struct llvmpipe_context *lp, key->occlusion_count = TRUE; } - if (lp->framebuffer.nr_cbufs) { - memcpy(&key->blend, lp->blend, sizeof key->blend); - } + memcpy(&key->blend, lp->blend, sizeof key->blend); key->coverage_samples = 1; key->min_samples = 1; -- 2.30.2