From 2d8dcb8135e454c47bc8609e3f9d89b29ef0b8d2 Mon Sep 17 00:00:00 2001 From: Hans-Peter Nilsson Date: Tue, 23 Feb 2016 02:06:45 +0100 Subject: [PATCH] Fix test-case ld-elf/pr19617b * elf32-cris.c (elf_cris_discard_excess_program_dynamics): Don't discard unused non-function symbols when --dynamic-list-data. --- bfd/ChangeLog | 6 ++++++ bfd/elf32-cris.c | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 1e0f6a13de3..611f9051b25 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2016-02-23 Hans-Peter Nilsson + + Fix test-case ld-elf/pr19617b + * elf32-cris.c (elf_cris_discard_excess_program_dynamics): Don't + discard unused non-function symbols when --dynamic-list-data. + 2016-02-22 H.J. Lu * elflink.c (_bfd_elf_link_renumber_dynsyms): Always create the diff --git a/bfd/elf32-cris.c b/bfd/elf32-cris.c index 7799cf4f041..64dc3ae5844 100644 --- a/bfd/elf32-cris.c +++ b/bfd/elf32-cris.c @@ -4032,8 +4032,10 @@ elf_cris_discard_excess_program_dynamics (struct elf_cris_link_hash_entry *h, have to export it as a dynamic symbol. This was already done for functions; doing this for all symbols would presumably not introduce new problems. Of course we don't do this if we're - exporting all dynamic symbols. */ - if (! info->export_dynamic + exporting all dynamic symbols, or all data symbols, regardless of + them being referenced or not. */ + if (! (info->export_dynamic + || (h->root.type != STT_FUNC && info->dynamic_data)) && h->root.dynindx != -1 && !h->root.def_dynamic && !h->root.ref_dynamic) -- 2.30.2