From 2dc63d39d31d56ce44154372c1d1771c73d22a68 Mon Sep 17 00:00:00 2001 From: Rhys Perry Date: Fri, 24 Jan 2020 17:37:11 +0000 Subject: [PATCH] aco: fix literal application with v_cndmask_b32/v_addc_co_u32/etc MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit No pipeline-db changes Signed-off-by: Rhys Perry Fixes: 0be74090696 ('aco: rewrite literal combining') Reviewed-by: Daniel Schürmann Tested-by: Marge Bot Part-of: --- src/amd/compiler/aco_optimizer.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/compiler/aco_optimizer.cpp b/src/amd/compiler/aco_optimizer.cpp index fbeb76df990..93d934c69ed 100644 --- a/src/amd/compiler/aco_optimizer.cpp +++ b/src/amd/compiler/aco_optimizer.cpp @@ -2674,6 +2674,9 @@ void select_instruction(opt_ctx &ctx, aco_ptr& instr) unsigned num_operands = 1; if (instr->isSALU() || (ctx.program->chip_class >= GFX10 && can_use_VOP3(ctx, instr))) num_operands = instr->operands.size(); + /* catch VOP2 with a 3rd SGPR operand (e.g. v_cndmask_b32, v_addc_co_u32) */ + else if (instr->isVALU() && instr->operands.size() >= 3) + return; unsigned sgpr_ids[2] = {0, 0}; bool is_literal_sgpr = false; -- 2.30.2