From 2f6e5d7e9d6a416093702b75a536e8fed5c30d03 Mon Sep 17 00:00:00 2001 From: Tristan Gingold Date: Fri, 23 Oct 2009 13:22:46 +0000 Subject: [PATCH] 2009-10-23 Tristan Gingold * objfiles.c (allocate_objfile): Remove useless test. Move declaration of last_one to the block that uses it. --- gdb/ChangeLog | 5 +++++ gdb/objfiles.c | 28 +++++++++++----------------- 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index dfc57fbdecc..0f66c4de104 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2009-10-23 Tristan Gingold + + * objfiles.c (allocate_objfile): Remove useless test. Move + declaration of last_one to the block that uses it. + 2009-10-22 Paul Pluzhnikov * disasm.h (DISASSEMBLY_OMIT_FNAME) New define. diff --git a/gdb/objfiles.c b/gdb/objfiles.c index 03a49a935e9..6082155c5e5 100644 --- a/gdb/objfiles.c +++ b/gdb/objfiles.c @@ -194,24 +194,16 @@ build_objfile_section_table (struct objfile *objfile) struct objfile * allocate_objfile (bfd *abfd, int flags) { - struct objfile *objfile = NULL; - struct objfile *last_one = NULL; + struct objfile *objfile; - /* If we don't support mapped symbol files, didn't ask for the file to be - mapped, or failed to open the mapped file for some reason, then revert - back to an unmapped objfile. */ - - if (objfile == NULL) - { - objfile = (struct objfile *) xmalloc (sizeof (struct objfile)); - memset (objfile, 0, sizeof (struct objfile)); - objfile->psymbol_cache = bcache_xmalloc (); - objfile->macro_cache = bcache_xmalloc (); - /* We could use obstack_specify_allocation here instead, but - gdb_obstack.h specifies the alloc/dealloc functions. */ - obstack_init (&objfile->objfile_obstack); - terminate_minimal_symbol_table (objfile); - } + objfile = (struct objfile *) xmalloc (sizeof (struct objfile)); + memset (objfile, 0, sizeof (struct objfile)); + objfile->psymbol_cache = bcache_xmalloc (); + objfile->macro_cache = bcache_xmalloc (); + /* We could use obstack_specify_allocation here instead, but + gdb_obstack.h specifies the alloc/dealloc functions. */ + obstack_init (&objfile->objfile_obstack); + terminate_minimal_symbol_table (objfile); objfile_alloc_data (objfile); @@ -266,6 +258,8 @@ allocate_objfile (bfd *abfd, int flags) object_files = objfile; else { + struct objfile *last_one; + for (last_one = object_files; last_one->next; last_one = last_one->next); -- 2.30.2