From 2fff6d712a2f60614485537316ec68a9cba4e249 Mon Sep 17 00:00:00 2001 From: Mark Mitchell Date: Fri, 21 Feb 2003 22:56:06 +0000 Subject: [PATCH] re PR c++/9749 (ICE in write_expression on invalid function prototype) PR c++/9749 * decl.c (grokdeclarator): Do not allow parameters with variably modified types. PR c++/9749 * g++.dg/parse/varmod1.C: New test. From-SVN: r63250 --- gcc/cp/ChangeLog | 6 ++++++ gcc/cp/decl.c | 7 +++++-- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/parse/varmod1.C | 7 +++++++ 4 files changed, 23 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/g++.dg/parse/varmod1.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 960c36dada6..00be1dd8f30 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2003-02-21 Mark Mitchell + + PR c++/9749 + * decl.c (grokdeclarator): Do not allow parameters with variably + modified types. + 2003-02-21 Nathan Sidwell * search.c (bfs_walk_grow): Remove. Fold into ... diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index 3f22b748618..caf389150d6 100644 --- a/gcc/cp/decl.c +++ b/gcc/cp/decl.c @@ -11085,11 +11085,14 @@ grokdeclarator (tree declarator, type = error_mark_node; } - if (decl_context == FIELD + if ((decl_context == FIELD || decl_context == PARM) && !processing_template_decl && variably_modified_type_p (type)) { - error ("data member may not have variably modified type `%T'", type); + if (decl_context == FIELD) + error ("data member may not have variably modified type `%T'", type); + else + error ("parameter may not have variably modified type `%T'", type); type = error_mark_node; } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index ed4f626fb2d..b015a6e9bef 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2003-02-21 Mark Mitchell + + PR c++/9749 + * g++.dg/parse/varmod1.C: New test. + 2003-02-21 Mark Mitchell PR c++/9727 diff --git a/gcc/testsuite/g++.dg/parse/varmod1.C b/gcc/testsuite/g++.dg/parse/varmod1.C new file mode 100644 index 00000000000..bf64507ae9b --- /dev/null +++ b/gcc/testsuite/g++.dg/parse/varmod1.C @@ -0,0 +1,7 @@ +int main(int argc, char** argv) { + int nx = 2; + void theerror(double a[][nx+1]); // { dg-error "" } + double** a; + theerror(a); // { dg-error "" } + return 0; +} -- 2.30.2