From 30440677f3d0cdd2085bea40496774ffa24f6bb1 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Thu, 12 Oct 2017 19:16:47 +0100 Subject: [PATCH] Tighten remote check in gdb.base/argv0-symlink.exp Check for gdbserver instead of dejagnu remote. Unlike what the comment says, the test actually fails with target remote + gdbserver (it does pass with extended-remote). The result is: FAIL -> KFAIL with --target_board=native-gdbserver KPASS -> PASS with --target_board=native-extended-gdbserver gdb/testsuite/ChangeLog: 2017-10-12 Pedro Alves Simon Marchi * gdb.base/argv0-symlink.exp: kfail on remote gdbserver, instead of on dejagnu remote boards. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.base/argv0-symlink.exp | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 0fa3afb0b64..e6a4281166d 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2017-10-12 Pedro Alves + Simon Marchi + + * gdb.base/argv0-symlink.exp: kfail on remote gdbserver, + instead of on dejagnu remote boards. + 2017-10-12 Pedro Alves Simon Marchi diff --git a/gdb/testsuite/gdb.base/argv0-symlink.exp b/gdb/testsuite/gdb.base/argv0-symlink.exp index a1248edbe00..efac9e0029c 100644 --- a/gdb/testsuite/gdb.base/argv0-symlink.exp +++ b/gdb/testsuite/gdb.base/argv0-symlink.exp @@ -80,8 +80,9 @@ gdb_test_no_output "set print repeats 10000" gdb_test_no_output "set print elements 10000" if { $has_argv0 } { - # gdbserver does not have this issue. - if ![is_remote target] { + # gdbserver in extended-remote mode does not have this issue. + # Plain remote does, however. + if {[target_info gdb_protocol] != "extended-remote" || ![target_is_gdbserver]} { setup_kfail "*-*-*" gdb/15934 } gdb_test {print argv[0]} "/$dirlink/$filelink\"" $test -- 2.30.2