From 30596893ab5c82081bfdf81cebe0b973f4e7c516 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Tue, 31 May 2022 20:59:04 +0930 Subject: [PATCH] sparc64 segfault in finish_dynamic_symbol SYMBOL_REFERENCES_LOCAL can return true for undefined symbols. This can result in a segfault when running sparc64 ld/testsuite/ld-vsb tests that expect a failure. * elfxx-sparc.c (_bfd_sparc_elf_finish_dynamic_symbol): Don't access u.def.section on non-default visibility undefined symbol. --- bfd/elfxx-sparc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bfd/elfxx-sparc.c b/bfd/elfxx-sparc.c index 618b88589c7..514db1e4c76 100644 --- a/bfd/elfxx-sparc.c +++ b/bfd/elfxx-sparc.c @@ -4416,7 +4416,10 @@ _bfd_sparc_elf_finish_dynamic_symbol (bfd *output_bfd, return true; } - if (bfd_link_pic (info) && SYMBOL_REFERENCES_LOCAL (info, h)) + if (bfd_link_pic (info) + && (h->root.type == bfd_link_hash_defined + || h->root.type == bfd_link_hash_defweak) + && SYMBOL_REFERENCES_LOCAL (info, h)) { asection *sec = h->root.u.def.section; if (h->type == STT_GNU_IFUNC) -- 2.30.2