From 31432a672fd40058a714eb2791ea1c3168ccc4f1 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Thu, 9 Nov 2017 11:58:37 -0800 Subject: [PATCH] fix typos in ada-lang.c comment gdb/ChangeLog: * ada-lang.c: Fix some typos in the general command documenting how Ada expressions are being evaluated and how their result is printed. --- gdb/ChangeLog | 6 ++++++ gdb/ada-lang.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 22434aa3434..59324f3b766 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2017-11-09 Joel Brobecker + + * ada-lang.c: Fix some typos in the general command documenting + how Ada expressions are being evaluated and how their result + is printed. + 2017-11-09 Tom Tromey * psymtab.c (psymbol_hash): Do not hash string contents. diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 749473355cc..ca5cdd1fb9e 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -10303,14 +10303,14 @@ ada_value_cast (struct type *type, struct value *arg2, enum noside noside) one element out of that array. On the other hand, fixing should not be performed on the elements when taking a slice of an array! - Note that one of the side-effects of miscomputing the offset and + Note that one of the side effects of miscomputing the offset and size of each field is that we end up also miscomputing the size of the containing type. This can have adverse results when computing the value of an entity. GDB fetches the value of an entity based on the size of its type, and thus a wrong size causes GDB to fetch the wrong amount of memory. In the case where the computed size is too small, GDB fetches too little data to print the value of our - entiry. Results in this case as unpredicatble, as we usually read + entity. Results in this case are unpredictable, as we usually read past the buffer containing the data =:-o. */ /* Implement the evaluate_exp routine in the exp_descriptor structure -- 2.30.2