From 3156469ca870821d972a3f9d242379b86e622c95 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Fri, 7 Mar 2014 09:00:27 -0800 Subject: [PATCH] target.h: Expands complete_target_initialization and add_target comments. Expand a bit the comments to answer some questions I had when looking at why a target of mine would not have some default methods set. gdb/ChangeLog: * target.h (complete_target_initialization, add_target): Add comment. --- gdb/ChangeLog | 5 +++++ gdb/target.h | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index fe176740119..ff962d40616 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-03-07 Joel Brobecker + + * target.h (complete_target_initialization, add_target): + Add comment. + 2014-03-07 Pedro Alves * go32-nat.c: Include inf-child.h. diff --git a/gdb/target.h b/gdb/target.h index 91f0cc96a3b..db9f5c35cc0 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -2006,9 +2006,13 @@ int target_verify_memory (const gdb_byte *data, /* Routines for maintenance of the target structures... complete_target_initialization: Finalize a target_ops by filling in - any fields needed by the target implementation. + any fields needed by the target implementation. Unnecessary for + targets which are registered via add_target, as this part gets + taken care of then. add_target: Add a target to the list of all possible targets. + This only makes sense for targets that should be activated using + the "target TARGET_NAME ..." command. push_target: Make this target the top of the stack of currently used targets, within its particular stratum of the stack. Result -- 2.30.2