From 31a43dd5e1cfb8bb387885b3f641d6d2c04ac5dd Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Tue, 25 Aug 2015 11:38:28 +0100 Subject: [PATCH] Remove some comments in debug_reg_change_callback gdb/gdbserver: 2015-08-25 Yao Qi * linux-aarch64-low.c (debug_reg_change_callback): Remove comments. --- gdb/gdbserver/ChangeLog | 4 ++++ gdb/gdbserver/linux-aarch64-low.c | 20 -------------------- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index d5eb882fbf4..0b7e658b91c 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2015-08-25 Yao Qi + + * linux-aarch64-low.c (debug_reg_change_callback): Remove comments. + 2015-08-25 Yao Qi * linux-aarch64-low.c (debug_reg_change_callback): Re-indent diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index 8b59eab6228..a8c2a24fa5a 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -276,26 +276,6 @@ debug_reg_change_callback (struct lwp_info *lwp, void *ptr) && (idx <= (is_watchpoint ? aarch64_num_wp_regs : aarch64_num_bp_regs))); - /* The following assertion is not right, as there can be changes - that have not been made to the hardware debug registers - before new changes overwrite the old ones. This can happen, - for instance, when the breakpoint/watchpoint hit one of the - threads and the user enters continue; then what happens is: - 1) all breakpoints/watchpoints are removed for all threads; - 2) a single step is carried out for the thread that was hit; - 3) all of the points are inserted again for all threads; - 4) all threads are resumed. - The 2nd step will only affect the one thread in which the - bp/wp was hit, which means only that one thread is resumed; - remember that the actual updating only happen in - aarch64_linux_prepare_to_resume, so other threads remain - stopped during the removal and insertion of bp/wp. Therefore - for those threads, the change of insertion of the bp/wp - overwrites that of the earlier removals. (The situation may - be different when bp/wp is steppable, or in the non-stop - mode.) */ - /* gdb_assert (DR_N_HAS_CHANGED (dr_changed, idx) == 0); */ - /* The actual update is done later just before resuming the lwp, we just mark that one register pair needs updating. */ DR_MARK_N_CHANGED (dr_changed, idx); -- 2.30.2