From 31b7833d205031b52996982f5da025d60c6e052f Mon Sep 17 00:00:00 2001 From: Jan Kratochvil Date: Mon, 15 Jun 2015 17:10:44 +0200 Subject: [PATCH] Code cleanup: Rename enum -> enum filterflags Bit mask ints are better to make enums as GDB already has support to automatically decode them: before this patch: (gdb) p filterflags $1 = 51 (gdb) p/x filterflags $2 = 0x33 after this patch: (gdb) p filterflags $1 = (COREFILTER_ANON_PRIVATE | COREFILTER_ANON_SHARED | COREFILTER_ELF_HEADERS | COREFILTER_HUGETLB_PRIVATE) gdb/ChangeLog 2015-06-15 Jan Kratochvil * linux-tdep.c (enum filterflags): Make it from anonymous enum. (dump_mapping_p): Use it for parameter filterflags. (linux_find_memory_regions_full): Use it for variable filterflags. --- gdb/ChangeLog | 6 ++++++ gdb/linux-tdep.c | 12 ++++++------ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index eeded49e65c..db7fb63852d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2015-06-15 Jan Kratochvil + + * linux-tdep.c (enum filterflags): Make it from anonymous enum. + (dump_mapping_p): Use it for parameter filterflags. + (linux_find_memory_regions_full): Use it for variable filterflags. + 2015-06-15 Aleksandar Ristovski diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c index f0cdc9c06da..c81f71bfd42 100644 --- a/gdb/linux-tdep.c +++ b/gdb/linux-tdep.c @@ -46,7 +46,7 @@ Documentation/filesystems/proc.txt, inside the Linux kernel tree. */ -enum +enum filterflags { COREFILTER_ANON_PRIVATE = 1 << 0, COREFILTER_ANON_SHARED = 1 << 1, @@ -598,7 +598,7 @@ mapping_is_anonymous_p (const char *filename) This should work OK enough, however. */ static int -dump_mapping_p (unsigned int filterflags, const struct smaps_vmflags *v, +dump_mapping_p (enum filterflags filterflags, const struct smaps_vmflags *v, int maybe_private_p, int mapping_anon_p, int mapping_file_p, const char *filename) { @@ -1119,10 +1119,10 @@ linux_find_memory_regions_full (struct gdbarch *gdbarch, /* Default dump behavior of coredump_filter (0x33), according to Documentation/filesystems/proc.txt from the Linux kernel tree. */ - unsigned int filterflags = (COREFILTER_ANON_PRIVATE - | COREFILTER_ANON_SHARED - | COREFILTER_ELF_HEADERS - | COREFILTER_HUGETLB_PRIVATE); + enum filterflags filterflags = (COREFILTER_ANON_PRIVATE + | COREFILTER_ANON_SHARED + | COREFILTER_ELF_HEADERS + | COREFILTER_HUGETLB_PRIVATE); /* We need to know the real target PID to access /proc. */ if (current_inferior ()->fake_pid_p) -- 2.30.2