From 32253bb7963ac7caa166ec41e336372f2ffc03d4 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Tue, 23 Jan 2018 10:50:02 +1030 Subject: [PATCH] Define __start/__stop symbols when there is only a dynamic def This patch fixes a case where a user had a C-representable named section in both the executable and shared libraries, and of course wanted the size of the local section in the executable, not the dynamic section. It does mean that __start and __stop symbols don't behave exactly like PROVIDEd symbols, but I think that's a reasonable difference particularly since this is the way they used to behave. * elflink.c (bfd_elf_define_start_stop): Override symbols when they are defined dynamically. --- bfd/ChangeLog | 5 +++++ bfd/elflink.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 4ad0127b213..2eb4916ce68 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2018-01-26 Alan Modra + + * elflink.c (bfd_elf_define_start_stop): Override symbols when + they are defined dynamically. + 2018-01-26 Alan Modra * elf64-ppc.c (ppc64_elf_size_stubs): Iterate sizing when diff --git a/bfd/elflink.c b/bfd/elflink.c index e3751fa122c..e81f6c6d820 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -14338,7 +14338,7 @@ bfd_elf_define_start_stop (struct bfd_link_info *info, if (h != NULL && (h->root.type == bfd_link_hash_undefined || h->root.type == bfd_link_hash_undefweak - || (h->ref_regular && !h->def_regular))) + || ((h->ref_regular || h->def_dynamic) && !h->def_regular))) { h->root.type = bfd_link_hash_defined; h->root.u.def.section = sec; -- 2.30.2