From 32ffbe9280fddada892bdd1c0f79479170a12610 Mon Sep 17 00:00:00 2001 From: Stuart Ballard Date: Wed, 26 Nov 2003 21:45:55 +0000 Subject: [PATCH] HashMap.java (putAll): Use Iterator hasNext() method. 2003-11-26 Stuart Ballard * java/util/HashMap.java (putAll): Use Iterator hasNext() method. (putAllInternal): Likewise. * java/util/Hashtable.java (putAll): Use Iterator hasNext() method. (putAllInternal): Likewise. From-SVN: r73964 --- libjava/ChangeLog | 7 +++++++ libjava/java/util/HashMap.java | 9 ++++----- libjava/java/util/Hashtable.java | 8 ++++---- 3 files changed, 15 insertions(+), 9 deletions(-) diff --git a/libjava/ChangeLog b/libjava/ChangeLog index 23d9adc1d4f..260c7ce12d6 100644 --- a/libjava/ChangeLog +++ b/libjava/ChangeLog @@ -1,3 +1,10 @@ +2003-11-26 Stuart Ballard + + * java/util/HashMap.java (putAll): Use Iterator hasNext() method. + (putAllInternal): Likewise. + * java/util/Hashtable.java (putAll): Use Iterator hasNext() method. + (putAllInternal): Likewise. + 2003-11-26 Michael Koch * java/net/URLStreamHandler.java diff --git a/libjava/java/util/HashMap.java b/libjava/java/util/HashMap.java index 6b3466ca15d..6317ba7cec1 100644 --- a/libjava/java/util/HashMap.java +++ b/libjava/java/util/HashMap.java @@ -381,8 +381,7 @@ public class HashMap extends AbstractMap public void putAll(Map m) { Iterator itr = m.entrySet().iterator(); - int msize = m.size(); - while (msize-- > 0) + while (itr.hasNext()) { Map.Entry e = (Map.Entry) itr.next(); // Optimize in case the Entry is one of our own. @@ -709,10 +708,10 @@ public class HashMap extends AbstractMap void putAllInternal(Map m) { Iterator itr = m.entrySet().iterator(); - int msize = m.size(); - size = msize; - while (msize-- > 0) + size = 0; + while (itr.hasNext()) { + size++; Map.Entry e = (Map.Entry) itr.next(); Object key = e.getKey(); int idx = hash(key); diff --git a/libjava/java/util/Hashtable.java b/libjava/java/util/Hashtable.java index a94143b8f09..b0de0a231b8 100644 --- a/libjava/java/util/Hashtable.java +++ b/libjava/java/util/Hashtable.java @@ -510,7 +510,7 @@ public class Hashtable extends Dictionary { Iterator itr = m.entrySet().iterator(); - for (int msize = m.size(); msize > 0; msize--) + while (itr.hasNext()) { Map.Entry e = (Map.Entry) itr.next(); // Optimize in case the Entry is one of our own. @@ -859,11 +859,11 @@ public class Hashtable extends Dictionary void putAllInternal(Map m) { Iterator itr = m.entrySet().iterator(); - int msize = m.size(); - this.size = msize; + size = 0; - for (; msize > 0; msize--) + while (itr.hasNext()) { + size++; Map.Entry e = (Map.Entry) itr.next(); Object key = e.getKey(); int idx = hash(key); -- 2.30.2