From 3322c5d9a102f9af099bd87cc65a1e2a70f91c78 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sat, 1 Sep 2018 10:23:48 -0600 Subject: [PATCH] Remove unneeded explicit .o targets Makefile.in had special cases to compile printcmd.o and target-float.o with a different set of warnings. However, this is no longer required, so this patch removes those rules. gdb/ChangeLog 2018-09-04 Tom Tromey * Makefile.in (printcmd.o, target-float.o): Remove. (GDB_WARN_CFLAGS_NO_FORMAT): Remove. --- gdb/ChangeLog | 5 +++++ gdb/Makefile.in | 16 ---------------- 2 files changed, 5 insertions(+), 16 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e126f80b80e..5aafde6ae27 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-09-04 Tom Tromey + + * Makefile.in (printcmd.o, target-float.o): Remove. + (GDB_WARN_CFLAGS_NO_FORMAT): Remove. + 2018-09-04 Tom Tromey * gnulib/Makefile.in: Remove obsolete comment. diff --git a/gdb/Makefile.in b/gdb/Makefile.in index e75ef66a070..16aac9dadf2 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -199,8 +199,6 @@ WERROR_CFLAGS = @WERROR_CFLAGS@ GDB_WARN_CFLAGS = $(WARN_CFLAGS) GDB_WERROR_CFLAGS = $(WERROR_CFLAGS) -GDB_WARN_CFLAGS_NO_FORMAT = `echo " $(GDB_WARN_CFLAGS) " \ - | sed "s/ -Wformat-nonliteral / -Wno-format-nonliteral /g"` GDB_WARN_CFLAGS_NO_DEFS = `echo " $(GDB_WARN_CFLAGS) " \ | sed "s/ -Wold-style-definition / -Wno-old-style-definition /g"` @@ -2383,20 +2381,6 @@ ALLDEPFILES = \ # Some files need explicit build rules (due to -Werror problems) or due # to sub-directory fun 'n' games. -# Do not try to build "printcmd.c" with -Wformat-nonliteral. It manually -# checks format strings. -printcmd.o: $(srcdir)/printcmd.c - $(ECHO_CXX) $(COMPILE.pre) $(INTERNAL_CFLAGS) \ - $(GDB_WARN_CFLAGS_NO_FORMAT) $(COMPILE.post) \ - $(srcdir)/printcmd.c - $(POSTCOMPILE) - -# Same for "target-float.c". -target-float.o: $(srcdir)/target-float.c - $(ECHO_CXX) $(COMPILE.pre) $(INTERNAL_CFLAGS) \ - $(GDB_WARN_CFLAGS_NO_FORMAT) $(COMPILE.post) \ - $(srcdir)/target-float.c - # ada-exp.c can appear in srcdir, for releases; or in ., for # development builds. ADA_EXP_C = `if test -f ada-exp.c; then echo ada-exp.c; else echo $(srcdir)/ada-exp.c; fi` -- 2.30.2