From 333988a73e06cb4067f113b7043ab68dd0e86c9d Mon Sep 17 00:00:00 2001 From: Lena Olson Date: Fri, 3 Apr 2015 11:42:10 -0500 Subject: [PATCH] x86: fix debug trace output for mwait When running with the Exec flag, the mwait instruction attempted to print out its source registers, which were never actually initialized. This led to sporadic assertion failures when the value stored there was invalid. Committed by: Nilay Vaish --- src/arch/x86/isa/formats/monitor_mwait.isa | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/arch/x86/isa/formats/monitor_mwait.isa b/src/arch/x86/isa/formats/monitor_mwait.isa index 493b7c58a..b26c1f267 100644 --- a/src/arch/x86/isa/formats/monitor_mwait.isa +++ b/src/arch/x86/isa/formats/monitor_mwait.isa @@ -112,9 +112,9 @@ output decoder {{ { std::stringstream response; + // Although mwait could take hints from eax and ecx, the _srcRegIdx + // is not set, and thus should not be printed here printMnemonic(response, mnemonic); - ccprintf(response, " "); - printReg(response, _srcRegIdx[0], machInst.opSize); return response.str(); } }}; -- 2.30.2