From 338a173e822298bd22741342a7b24352450afdd1 Mon Sep 17 00:00:00 2001 From: Javier Bueno Date: Thu, 15 Nov 2018 16:19:45 +0100 Subject: [PATCH] mem-cache: fix invalid iterator access An iterator was assigned end() and then it was used to access its corresponding element. Change-Id: I87246cf56cbc694dd6b4e2cabbe84a08429d2ac3 Reviewed-on: https://gem5-review.googlesource.com/c/14361 Reviewed-by: Nikos Nikoleris Reviewed-by: Daniel Carvalho Maintainer: Nikos Nikoleris --- src/mem/cache/prefetch/queued.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mem/cache/prefetch/queued.cc b/src/mem/cache/prefetch/queued.cc index ce14b5ac5..ba4c940c1 100644 --- a/src/mem/cache/prefetch/queued.cc +++ b/src/mem/cache/prefetch/queued.cc @@ -265,8 +265,9 @@ QueuedPrefetcher::insert(AddrPriority &pf_info, bool is_secure) pfq.emplace_back(dpp); } else { iterator it = pfq.end(); - while (it != pfq.begin() && dpp > *it) + do { --it; + } while (it != pfq.begin() && dpp > *it); /* If we reach the head, we have to see if the new element is new head * or not */ if (it == pfq.begin() && dpp <= *it) -- 2.30.2