From 33906eeaca917506cfa4297913c386121357531e Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Mon, 7 May 2018 11:23:27 -0700 Subject: [PATCH] intel/genxml: Make assert in gen_pack_header print a message. Python's assert can take both a condition and a string, which will cause it to print the string if the assertion trips. (You can't use parens as that creates a tuple.) Doing "condition and string" works in C, but doesn't have the desired effect in Python. Reviewed-by: Caio Marcelo de Oliveira Filho Reviewed-by: Jason Ekstrand --- src/intel/genxml/gen_pack_header.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/genxml/gen_pack_header.py b/src/intel/genxml/gen_pack_header.py index 6a4c8033a70..4bce425d12e 100644 --- a/src/intel/genxml/gen_pack_header.py +++ b/src/intel/genxml/gen_pack_header.py @@ -220,7 +220,7 @@ def num_from_str(num_str): if num_str.lower().startswith('0x'): return int(num_str, base=16) else: - assert(not num_str.startswith('0') and 'octals numbers not allowed') + assert not num_str.startswith('0'), 'octals numbers not allowed' return int(num_str) class Field(object): -- 2.30.2