From 33e89989f63ba5148362ecbdaed7d6c62e74e8ea Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Fri, 29 Jan 2016 15:14:56 +0100 Subject: [PATCH] re PR target/69551 (Wrong code with single element vector insert) PR target/69551 * config/i386/i386.c (ix86_expand_vector_set) : For SSE1, copy target into the temporary reg first before recursing on it. * gcc.target/i386/pr69551.c: New test. From-SVN: r232982 --- gcc/ChangeLog | 7 +++++++ gcc/config/i386/i386.c | 1 + gcc/testsuite/ChangeLog | 3 +++ gcc/testsuite/gcc.target/i386/pr69551.c | 23 +++++++++++++++++++++++ 4 files changed, 34 insertions(+) create mode 100644 gcc/testsuite/gcc.target/i386/pr69551.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 8e06ddb9e17..9f998427113 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2016-01-29 Jakub Jelinek + + PR target/69551 + * config/i386/i386.c (ix86_expand_vector_set) : For + SSE1, copy target into the temporary reg first before recursing + on it. + 2016-01-29 H.J. Lu * config/i386/sse.md (sse2_cvtps2pd): Replace vBm diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 6dc1fa54e9b..b5002337cf4 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -46744,6 +46744,7 @@ ix86_expand_vector_set (bool mmx_ok, rtx target, rtx val, int elt) { /* For SSE1, we have to reuse the V4SF code. */ rtx t = gen_reg_rtx (V4SFmode); + emit_move_insn (t, gen_lowpart (V4SFmode, target)); ix86_expand_vector_set (false, t, gen_lowpart (SFmode, val), elt); emit_move_insn (target, gen_lowpart (mode, t)); } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index e41c9896de2..150ebc803ac 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,8 @@ 2016-01-29 Jakub Jelinek + PR target/69551 + * gcc.target/i386/pr69551.c: New test. + PR target/66137 * gcc.target/i386/pr66137.c: New test. diff --git a/gcc/testsuite/gcc.target/i386/pr69551.c b/gcc/testsuite/gcc.target/i386/pr69551.c new file mode 100644 index 00000000000..1505fc21dbf --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr69551.c @@ -0,0 +1,23 @@ +/* PR target/69551 */ +/* { dg-do run { target sse_runtime } } */ +/* { dg-options "-O2 -mno-sse2 -msse" } */ + +typedef unsigned char v16qi __attribute__ ((vector_size (16))); +typedef unsigned int v4si __attribute__ ((vector_size (16))); + +char __attribute__ ((noinline, noclone)) +test (v4si vec) +{ + vec[1] = 0x5fb856; + return ((v16qi) vec)[0]; +} + +int +main () +{ + char z = test ((v4si) { -1, -1, -1, -1 }); + + if (z != -1) + __builtin_abort (); + return 0; +} -- 2.30.2