From 34c703da6cb01d8b41e1bfb790c3c2c625088b69 Mon Sep 17 00:00:00 2001 From: Gary Benson Date: Tue, 24 Mar 2015 14:05:44 +0000 Subject: [PATCH] Change signature of linux_target_ops.new_thread This commit changes the signature of linux_target_ops.new_thread in gdbserver to match that used in GDB's equivalent. gdb/gdbserver/ChangeLog: * linux-low.h (linux_target_ops) : Changed signature. * linux-arm-low.c (arm_new_thread): Likewise. * linux-aarch64-low.c (aarch64_linux_new_thread): Likewise. * linux-mips-low.c (mips_linux_new_thread): Likewise. * linux-x86-low.c (x86_linux_new_thread): Likewise. * linux-low.c (add_lwp): Update the_low_target.new_thread call. --- gdb/gdbserver/ChangeLog | 9 +++++++++ gdb/gdbserver/linux-aarch64-low.c | 6 +++--- gdb/gdbserver/linux-arm-low.c | 6 +++--- gdb/gdbserver/linux-low.c | 2 +- gdb/gdbserver/linux-low.h | 2 +- gdb/gdbserver/linux-mips-low.c | 6 +++--- gdb/gdbserver/linux-x86-low.c | 6 +++--- 7 files changed, 23 insertions(+), 14 deletions(-) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index a77f04ba705..1f5e4c12ca6 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,12 @@ +2015-03-24 Gary Benson + + * linux-low.h (linux_target_ops) : Changed signature. + * linux-arm-low.c (arm_new_thread): Likewise. + * linux-aarch64-low.c (aarch64_linux_new_thread): Likewise. + * linux-mips-low.c (mips_linux_new_thread): Likewise. + * linux-x86-low.c (x86_linux_new_thread): Likewise. + * linux-low.c (add_lwp): Update the_low_target.new_thread call. + 2015-03-24 Gary Benson * linux-low.c (ptid_of_lwp): New function. diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index 7934e78575f..d44175ef8e0 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -1121,8 +1121,8 @@ aarch64_linux_new_process (void) /* Called when a new thread is detected. */ -static struct arch_lwp_info * -aarch64_linux_new_thread (void) +static void +aarch64_linux_new_thread (struct lwp_info *lwp) { struct arch_lwp_info *info = xcalloc (1, sizeof (*info)); @@ -1132,7 +1132,7 @@ aarch64_linux_new_thread (void) DR_MARK_ALL_CHANGED (info->dr_changed_bp, aarch64_num_bp_regs); DR_MARK_ALL_CHANGED (info->dr_changed_wp, aarch64_num_wp_regs); - return info; + lwp->arch_private = info; } /* Called when resuming a thread. diff --git a/gdb/gdbserver/linux-arm-low.c b/gdb/gdbserver/linux-arm-low.c index 2cd16682574..d408dcda2ef 100644 --- a/gdb/gdbserver/linux-arm-low.c +++ b/gdb/gdbserver/linux-arm-low.c @@ -703,8 +703,8 @@ arm_new_process (void) } /* Called when a new thread is detected. */ -static struct arch_lwp_info * -arm_new_thread (void) +static void +arm_new_thread (struct lwp_info *lwp) { struct arch_lwp_info *info = xcalloc (1, sizeof (*info)); int i; @@ -714,7 +714,7 @@ arm_new_thread (void) for (i = 0; i < MAX_WPTS; i++) info->wpts_changed[i] = 1; - return info; + lwp->arch_private = info; } /* Called when resuming a thread. diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index f2a22246015..93656c0b4c8 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -640,7 +640,7 @@ add_lwp (ptid_t ptid) memset (lwp, 0, sizeof (*lwp)); if (the_low_target.new_thread != NULL) - lwp->arch_private = the_low_target.new_thread (); + the_low_target.new_thread (lwp); lwp->thread = add_thread (ptid, lwp); diff --git a/gdb/gdbserver/linux-low.h b/gdb/gdbserver/linux-low.h index 5c52b14f001..1ae37017f57 100644 --- a/gdb/gdbserver/linux-low.h +++ b/gdb/gdbserver/linux-low.h @@ -185,7 +185,7 @@ struct linux_target_ops /* Hook to call when a new thread is detected. If extra per-thread architecture-specific data is needed, allocate it here. */ - struct arch_lwp_info * (*new_thread) (void); + void (*new_thread) (struct lwp_info *); /* Hook to call prior to resuming a thread. */ void (*prepare_to_resume) (struct lwp_info *); diff --git a/gdb/gdbserver/linux-mips-low.c b/gdb/gdbserver/linux-mips-low.c index f081dda9ba2..7988d073dac 100644 --- a/gdb/gdbserver/linux-mips-low.c +++ b/gdb/gdbserver/linux-mips-low.c @@ -334,14 +334,14 @@ mips_linux_new_process (void) Mark the watch registers as changed, so the threads' copies will be updated. */ -static struct arch_lwp_info * -mips_linux_new_thread (void) +static void +mips_linux_new_thread (struct lwp_info *lwp) { struct arch_lwp_info *info = xcalloc (1, sizeof (*info)); info->watch_registers_changed = 1; - return info; + lwp->arch_private = info; } /* This is the implementation of linux_target_ops method diff --git a/gdb/gdbserver/linux-x86-low.c b/gdb/gdbserver/linux-x86-low.c index 43bf8296f5e..4a7cf42fa6b 100644 --- a/gdb/gdbserver/linux-x86-low.c +++ b/gdb/gdbserver/linux-x86-low.c @@ -757,14 +757,14 @@ x86_linux_new_process (void) /* Called when a new thread is detected. */ -static struct arch_lwp_info * -x86_linux_new_thread (void) +static void +x86_linux_new_thread (struct lwp_info *lwp) { struct arch_lwp_info *info = XCNEW (struct arch_lwp_info); info->debug_registers_changed = 1; - return info; + lwp->arch_private = info; } /* See nat/x86-dregs.h. */ -- 2.30.2