From 351d513e30b3d09f39ee73169fc68e7cdaca1d11 Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Fri, 3 Apr 2020 12:23:27 +0200 Subject: [PATCH] egl/entrypoint-check: split sort-check into a function Cc: mesa-stable Signed-off-by: Eric Engestrom Reviewed-by: Emil Velikov Part-of: --- src/egl/egl-entrypoint-check.py | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/src/egl/egl-entrypoint-check.py b/src/egl/egl-entrypoint-check.py index 1e876615028..7cbb8a7708a 100644 --- a/src/egl/egl-entrypoint-check.py +++ b/src/egl/egl-entrypoint-check.py @@ -5,6 +5,21 @@ import argparse PREFIX = 'EGL_ENTRYPOINT(' SUFFIX = ')' + +def check_entrypoint_sorted(entrypoints): + print('Checking that EGL API entrypoints are sorted...') + + for i, _ in enumerate(entrypoints): + # Can't compare the first one with the previous + if i == 0: + continue + if entrypoints[i - 1] > entrypoints[i]: + print('ERROR: ' + entrypoints[i] + ' should come before ' + entrypoints[i - 1]) + exit(1) + + print('All good :)') + + def main(): parser = argparse.ArgumentParser() parser.add_argument('header') @@ -20,17 +35,7 @@ def main(): assert line.endswith(SUFFIX) entrypoints.append(line[len(PREFIX):-len(SUFFIX)]) - print('Checking EGL API entrypoints are sorted') - - for i, _ in enumerate(entrypoints): - # Can't compare the first one with the previous - if i == 0: - continue - if entrypoints[i - 1] > entrypoints[i]: - print('ERROR: ' + entrypoints[i] + ' should come before ' + entrypoints[i - 1]) - exit(1) - - print('All good :)') + check_entrypoint_sorted(entrypoints) if __name__ == '__main__': main() -- 2.30.2