From 3524a83e5950576a807134dde6c180211219e655 Mon Sep 17 00:00:00 2001 From: Jan Vrany Date: Mon, 8 Nov 2021 10:46:07 +0000 Subject: [PATCH] gdb/mi: rename mi_lookup to mi_cmd_lookup Lets give this function a more descriptive name. I've also improved the comments in the header and source files. There should be no user visible changes after this commit. --- gdb/mi/mi-cmd-info.c | 2 +- gdb/mi/mi-cmds.c | 5 +++-- gdb/mi/mi-cmds.h | 5 +++-- gdb/mi/mi-parse.c | 2 +- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/gdb/mi/mi-cmd-info.c b/gdb/mi/mi-cmd-info.c index 78377dc32e7..c2858519a4c 100644 --- a/gdb/mi/mi-cmd-info.c +++ b/gdb/mi/mi-cmd-info.c @@ -82,7 +82,7 @@ mi_cmd_info_gdb_mi_command (const char *command, char **argv, int argc) if (cmd_name[0] == '-') cmd_name++; - cmd = mi_lookup (cmd_name); + cmd = mi_cmd_lookup (cmd_name); ui_out_emit_tuple tuple_emitter (uiout, "command"); uiout->field_string ("exists", cmd != NULL ? "true" : "false"); diff --git a/gdb/mi/mi-cmds.c b/gdb/mi/mi-cmds.c index 1ed8b6f9126..8899fdd3a1e 100644 --- a/gdb/mi/mi-cmds.c +++ b/gdb/mi/mi-cmds.c @@ -211,9 +211,10 @@ enum MI_TABLE_SIZE = 227 }; -/* Exported function used to obtain info from the table. */ +/* See mi-cmds.h. */ + struct mi_cmd * -mi_lookup (const char *command) +mi_cmd_lookup (const char *command) { return *lookup_table (command); } diff --git a/gdb/mi/mi-cmds.h b/gdb/mi/mi-cmds.h index 8da2e393919..e92737be8c8 100644 --- a/gdb/mi/mi-cmds.h +++ b/gdb/mi/mi-cmds.h @@ -164,9 +164,10 @@ struct mi_cmd int *suppress_notification; }; -/* Lookup a command in the MI command table. */ +/* Lookup a command in the MI command table, returns nullptr if COMMAND is + not found. */ -extern struct mi_cmd *mi_lookup (const char *command); +extern struct mi_cmd *mi_cmd_lookup (const char *command); /* Debug flag */ extern int mi_debug_p; diff --git a/gdb/mi/mi-parse.c b/gdb/mi/mi-parse.c index 4d6afa93e1f..b5b01cf4db0 100644 --- a/gdb/mi/mi-parse.c +++ b/gdb/mi/mi-parse.c @@ -272,7 +272,7 @@ mi_parse (const char *cmd, char **token) } /* Find the command in the MI table. */ - parse->cmd = mi_lookup (parse->command); + parse->cmd = mi_cmd_lookup (parse->command); if (parse->cmd == NULL) throw_error (UNDEFINED_COMMAND_ERROR, _("Undefined MI command: %s"), parse->command); -- 2.30.2