From 3610b066c2850b9d4ce1f69cddac505cdd80faf2 Mon Sep 17 00:00:00 2001
From: Ilia Sergachev <ilia.sergachev@protonmail.ch>
Date: Tue, 16 Jun 2020 01:06:11 +0200
Subject: [PATCH] build/sim/core/modules: fix compilation warnings

---
 litex/build/sim/core/modules/clocker/clocker.c               | 4 ++--
 litex/build/sim/core/modules/ethernet/ethernet.c             | 4 ++--
 litex/build/sim/core/modules/serial2console/serial2console.c | 4 ++--
 litex/build/sim/core/modules/serial2tcp/serial2tcp.c         | 4 ++--
 litex/build/sim/core/modules/spdeeprom/spdeeprom.c           | 4 ++--
 litex/build/sim/core/modules/xgmii_ethernet/xgmii_ethernet.c | 5 ++---
 6 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/litex/build/sim/core/modules/clocker/clocker.c b/litex/build/sim/core/modules/clocker/clocker.c
index 1b2b9db0..cfd2f103 100644
--- a/litex/build/sim/core/modules/clocker/clocker.c
+++ b/litex/build/sim/core/modules/clocker/clocker.c
@@ -10,7 +10,7 @@ struct session_s {
 
 static int litex_sim_module_pads_get( struct pad_s *pads, char *name, void **signal)
 {
-  int ret;
+  int ret = RC_OK;
   void *sig=NULL;
   int i;
 
@@ -42,7 +42,7 @@ static int clocker_start()
 
 static int clocker_new(void **sess, char *args)
 {
-  int ret=RC_OK;
+  int ret = RC_OK;
 
   struct session_s *s=NULL;
 
diff --git a/litex/build/sim/core/modules/ethernet/ethernet.c b/litex/build/sim/core/modules/ethernet/ethernet.c
index 977899f0..30aca3f3 100644
--- a/litex/build/sim/core/modules/ethernet/ethernet.c
+++ b/litex/build/sim/core/modules/ethernet/ethernet.c
@@ -74,7 +74,7 @@ out:
 
 static int litex_sim_module_pads_get(struct pad_s *pads, char *name, void **signal)
 {
-  int ret;
+  int ret = RC_OK;
   void *sig = NULL;
   int i;
 
@@ -177,7 +177,7 @@ out:
 
 static int ethernet_add_pads(void *sess, struct pad_list_s *plist)
 {
-  int ret=RC_OK;
+  int ret = RC_OK;
   struct session_s *s = (struct session_s*)sess;
   struct pad_s *pads;
   if(!sess || !plist) {
diff --git a/litex/build/sim/core/modules/serial2console/serial2console.c b/litex/build/sim/core/modules/serial2console/serial2console.c
index c32b568f..114947f5 100644
--- a/litex/build/sim/core/modules/serial2console/serial2console.c
+++ b/litex/build/sim/core/modules/serial2console/serial2console.c
@@ -27,7 +27,7 @@ struct session_s {
 struct event_base *base;
 static int litex_sim_module_pads_get(struct pad_s *pads, char *name, void **signal)
 {
-  int ret;
+  int ret = RC_OK;
   void *sig = NULL;
   int i;
 
@@ -95,7 +95,7 @@ static void event_handler(int fd, short event, void *arg)
 
 static int serial2console_new(void **sess, char *args)
 {
-  int ret=RC_OK;
+  int ret = RC_OK;
   struct timeval tv = {1, 0};
   struct session_s *s = NULL;
 
diff --git a/litex/build/sim/core/modules/serial2tcp/serial2tcp.c b/litex/build/sim/core/modules/serial2tcp/serial2tcp.c
index 82fe4fba..8691d175 100644
--- a/litex/build/sim/core/modules/serial2tcp/serial2tcp.c
+++ b/litex/build/sim/core/modules/serial2tcp/serial2tcp.c
@@ -62,7 +62,7 @@ out:
 
 static int litex_sim_module_pads_get( struct pad_s *pads, char *name, void **signal)
 {
-  int ret;
+  int ret = RC_OK;
   void *sig = NULL;
   int i;
 
@@ -186,7 +186,7 @@ out:
 
 static int serial2tcp_add_pads(void *sess, struct pad_list_s *plist)
 {
-  int ret=RC_OK;
+  int ret = RC_OK;
   struct session_s *s=(struct session_s*)sess;
   struct pad_s *pads;
   if(!sess || !plist) {
diff --git a/litex/build/sim/core/modules/spdeeprom/spdeeprom.c b/litex/build/sim/core/modules/spdeeprom/spdeeprom.c
index 27b37c9c..1d1584fe 100644
--- a/litex/build/sim/core/modules/spdeeprom/spdeeprom.c
+++ b/litex/build/sim/core/modules/spdeeprom/spdeeprom.c
@@ -99,7 +99,7 @@ static int spdeeprom_start()
 
 static int spdeeprom_new(void **sess, char *args)
 {
-  int ret=RC_OK;
+  int ret = RC_OK;
   int i;
   char *spd_filename;
   FILE *spd_file;
@@ -403,7 +403,7 @@ static void spdeeprom_from_file(struct session_s *s, FILE *file)
 
 static int litex_sim_module_pads_get(struct pad_s *pads, char *name, void **signal)
 {
-  int ret;
+  int ret = RC_OK;
   void *sig=NULL;
   int i;
 
diff --git a/litex/build/sim/core/modules/xgmii_ethernet/xgmii_ethernet.c b/litex/build/sim/core/modules/xgmii_ethernet/xgmii_ethernet.c
index 45f7fc75..4474e1f2 100644
--- a/litex/build/sim/core/modules/xgmii_ethernet/xgmii_ethernet.c
+++ b/litex/build/sim/core/modules/xgmii_ethernet/xgmii_ethernet.c
@@ -96,7 +96,7 @@ out:
 
 static int litex_sim_module_pads_get(struct pad_s *pads, char *name, void **signal)
 {
-  int ret;
+  int ret = RC_OK;
   void *sig = NULL;
   int i;
 
@@ -199,7 +199,7 @@ out:
 
 static int xgmii_ethernet_add_pads(void *sess, struct pad_list_s *plist)
 {
-  int ret=RC_OK;
+  int ret = RC_OK;
   struct session_s *s = (struct session_s*)sess;
   struct pad_s *pads;
   if(!sess || !plist) {
@@ -358,7 +358,6 @@ static int xgmii_ethernet_tick(void *sess)
       printf("Received: %ld\n", s->ethpack->len );
       for(int i=0; i< s->ethpack->len;) {
 	printf("%02x ", s->inbuf[i++] & 0xff);
-	if (i%8 == 0 && i > 0);
       }
       printf("\n");
       s->inlen = s->ethpack->len;
-- 
2.30.2