From 36633dcc4a70d3b57829bff8120db8fe7423de09 Mon Sep 17 00:00:00 2001 From: Jim Kingdon Date: Tue, 14 Mar 1995 14:59:24 +0000 Subject: [PATCH] * valops.c (value_cast, value_slice), parse.c (follow_types): Add FIXME-type-allocation comments. --- gdb/ChangeLog | 3 +++ gdb/parse.c | 4 ++++ gdb/valops.c | 5 +++++ 3 files changed, 12 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a1c99b88965..a93c97f08b1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,8 @@ Tue Mar 14 05:52:36 1995 Jim Kingdon (kingdon@lioth.cygnus.com) + * valops.c (value_cast, value_slice), parse.c (follow_types): Add + FIXME-type-allocation comments. + * gdbtypes.h (struct type): Fix comment about what units the TYPE_LENGTH is in. diff --git a/gdb/parse.c b/gdb/parse.c index daa0ae60d76..36f7c3917b4 100644 --- a/gdb/parse.c +++ b/gdb/parse.c @@ -875,6 +875,8 @@ follow_types (follow_type) break; case tp_array: array_size = pop_type_int (); + /* FIXME-type-allocation: need a way to free this type when we are + done with it. */ range_type = create_range_type ((struct type *) NULL, builtin_type_int, 0, @@ -887,6 +889,8 @@ follow_types (follow_type) = BOUND_CANNOT_BE_DETERMINED; break; case tp_function: + /* FIXME-type-allocation: need a way to free this type when we are + done with it. */ follow_type = lookup_function_type (follow_type); break; } diff --git a/gdb/valops.c b/gdb/valops.c index ad3d8f99dce..fdd94e5a977 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -140,6 +140,8 @@ value_cast (type, arg2) int new_length = val_length / TYPE_LENGTH (element_type); if (val_length % TYPE_LENGTH (element_type) != 0) warning("array element type size does not divide object size in cast"); + /* FIXME-type-allocation: need a way to free this type when we are + done with it. */ range_type = create_range_type ((struct type *) NULL, TYPE_TARGET_TYPE (range_type), low_bound, new_length + low_bound - 1); @@ -2054,6 +2056,7 @@ value_slice (array, lowbound, length) value_ptr array; int lowbound, length; { + COERCE_VARYING_ARRAY (array); if (TYPE_CODE (VALUE_TYPE (array)) == TYPE_CODE_BITSTRING) error ("not implemented - bitstring slice"); if (TYPE_CODE (VALUE_TYPE (array)) != TYPE_CODE_ARRAY @@ -2071,6 +2074,8 @@ value_slice (array, lowbound, length) if (lowbound < lowerbound || length < 0 || lowbound + length - 1 > upperbound) error ("slice out of range"); + /* FIXME-type-allocation: need a way to free this type when we are + done with it. */ slice_range_type = create_range_type ((struct type*) NULL, TYPE_TARGET_TYPE (range_type), lowerbound, -- 2.30.2