From 36c1cf710de19ec2556fedf49a6ebfa4758e404f Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Wed, 22 Mar 2017 21:02:53 +0000 Subject: [PATCH] compiler: initialize gogo fields A couple of the data members in the Gogo class were not being initialized properly. This was causing "uninitialized value" errors during Valgrind memcheck runs. This patch insures that all of the fields receive an initial value. Reviewed-on: https://go-review.googlesource.com/38470 From-SVN: r246407 --- gcc/go/gofrontend/go.cc | 6 ++---- gcc/go/gofrontend/gogo.cc | 5 +++++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/gcc/go/gofrontend/go.cc b/gcc/go/gofrontend/go.cc index e0e84e3adc2..7050accbc5e 100644 --- a/gcc/go/gofrontend/go.cc +++ b/gcc/go/gofrontend/go.cc @@ -34,10 +34,8 @@ go_create_gogo(const struct go_create_gogo_args* args) if (args->relative_import_path != NULL) ::gogo->set_relative_import_path(args->relative_import_path); - if (args->check_divide_by_zero) - ::gogo->set_check_divide_by_zero(args->check_divide_by_zero); - if (args->check_divide_overflow) - ::gogo->set_check_divide_overflow(args->check_divide_overflow); + ::gogo->set_check_divide_by_zero(args->check_divide_by_zero); + ::gogo->set_check_divide_overflow(args->check_divide_overflow); if (args->compiling_runtime) ::gogo->set_compiling_runtime(args->compiling_runtime); if (args->c_header != NULL) diff --git a/gcc/go/gofrontend/gogo.cc b/gcc/go/gofrontend/gogo.cc index c5ce5d9ecec..a190917512a 100644 --- a/gcc/go/gofrontend/gogo.cc +++ b/gcc/go/gofrontend/gogo.cc @@ -50,6 +50,11 @@ Gogo::Gogo(Backend* backend, Linemap* linemap, int, int pointer_size) pkgpath_from_option_(false), prefix_from_option_(false), relative_import_path_(), + c_header_(), + check_divide_by_zero_(true), + check_divide_overflow_(true), + compiling_runtime_(false), + debug_escape_level_(0), verify_types_(), interface_types_(), specific_type_functions_(), -- 2.30.2