From 36e4ffa382f9f82ff6d7ed1dd4fc66010ed48fea Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Mon, 4 May 2020 14:09:39 -0400 Subject: [PATCH] pan/bit: Use swizzle helper for round Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/bifrost/test/bi_test_pack.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/panfrost/bifrost/test/bi_test_pack.c b/src/panfrost/bifrost/test/bi_test_pack.c index 69b9f695e77..2f02db12c9b 100644 --- a/src/panfrost/bifrost/test/bi_test_pack.c +++ b/src/panfrost/bifrost/test/bi_test_pack.c @@ -346,15 +346,11 @@ bit_round_helper(struct panfrost_device *dev, uint32_t *input, unsigned sz, bool bi_instruction ins = bit_ins(BI_ROUND, 1, nir_type_float, sz); for (enum bifrost_roundmode mode = 0; mode <= 3; ++mode) { - for (unsigned swizzle = 0; swizzle < (sz == 16 ? 4 : 1); ++swizzle) { - if (sz == 16) { - for (unsigned i = 0; i < 2; ++i) - ins.swizzle[0][i] = ((swizzle >> i) & 1) ? 1 : 0; - } - - ins.roundmode = mode; - bit_test_single(dev, &ins, input, FMA, debug); - } + BIT_FOREACH_SWIZZLE(swz, 1, sz) { + bit_apply_swizzle(&ins, swz, 1, sz); + ins.roundmode = mode; + bit_test_single(dev, &ins, input, FMA, debug); + } } } -- 2.30.2