From 36efe0aea5f7e5088f79e4c8d0265de0c0ec2be9 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Thu, 10 Sep 2020 18:46:14 +0930 Subject: [PATCH] Re: PR26580, Size and alignment of commons vs as-needed shared lib Some MIPS targets, for reasons I didn't analyse, use the larger common symbol in a shared lib rather than a smaller common in an executable. That doesn't seem unreasonable, so allow that to pass for pr26580-2. bfin-elf complains about not supporting copy relocs, but it's quite silly to want a copy reloc for common symbols, so leave the fail there. mn10300-elf and score-elf both fail the test with "PHDR segment not covered by LOAD segment". Other tests fail similarly so one more doesn't hurt. The failure is a consequence of supporting dynamic objects but setting EMBEDDED in ld scripts. PR 26580 * testsuite/ld-elf/pr26580-2.sd: Accept undefined symbol. --- ld/ChangeLog | 4 ++++ ld/testsuite/ld-elf/pr26580-2.sd | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ld/ChangeLog b/ld/ChangeLog index 621167de0fb..46a4aca2a56 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,7 @@ +2020-09-10 Alan Modra + + * testsuite/ld-elf/pr26580-2.sd: Accept undefined symbol. + 2020-09-10 Alan Modra * testsuite/ld-plugin/lto-18b.c (select): Remove. diff --git a/ld/testsuite/ld-elf/pr26580-2.sd b/ld/testsuite/ld-elf/pr26580-2.sd index 265b880f81a..10474ca23d4 100644 --- a/ld/testsuite/ld-elf/pr26580-2.sd +++ b/ld/testsuite/ld-elf/pr26580-2.sd @@ -1,4 +1,4 @@ #... -.* 8 OBJECT GLOBAL DEFAULT .* one +.* (8 OBJECT GLOBAL DEFAULT .*|0 OBJECT GLOBAL DEFAULT UND) one #pass -- 2.30.2