From 3723fda829671b273d7b31a0753bb1fa8f614cb6 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 28 Jul 2015 11:01:49 -0400 Subject: [PATCH] Update comments in struct value for non-8-bits architectures gdb/ChangeLog: * value.c (struct value): Update comments. --- gdb/ChangeLog | 4 ++++ gdb/value.c | 30 +++++++++++++++--------------- 2 files changed, 19 insertions(+), 15 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 380ff42a516..1e83384c130 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2015-07-28 Simon Marchi + + * value.c (struct value): Update comments. + 2015-07-28 Simon Marchi * gdbtypes.c (type_length_units): New function. diff --git a/gdb/value.c b/gdb/value.c index 4399493229e..7fb7e2b5307 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -234,11 +234,11 @@ struct value } computed; } location; - /* Describes offset of a value within lval of a structure in bytes. - If lval == lval_memory, this is an offset to the address. If - lval == lval_register, this is a further offset from - location.address within the registers structure. Note also the - member embedded_offset below. */ + /* Describes offset of a value within lval of a structure in target + addressable memory units. If lval == lval_memory, this is an offset to + the address. If lval == lval_register, this is a further offset from + location.address within the registers structure. Note also the member + embedded_offset below. */ int offset; /* Only used for bitfields; number of bits contained in them. */ @@ -291,19 +291,19 @@ struct value When we store the entire object, `enclosing_type' is the run-time type -- the complete object -- and `embedded_offset' is the - offset of `type' within that larger type, in bytes. The - value_contents() macro takes `embedded_offset' into account, so - most GDB code continues to see the `type' portion of the value, - just as the inferior would. + offset of `type' within that larger type, in target addressable memory + units. The value_contents() macro takes `embedded_offset' into account, + so most GDB code continues to see the `type' portion of the value, just + as the inferior would. If `type' is a pointer to an object, then `enclosing_type' is a pointer to the object's run-time type, and `pointed_to_offset' is - the offset in bytes from the full object to the pointed-to object - -- that is, the value `embedded_offset' would have if we followed - the pointer and fetched the complete object. (I don't really see - the point. Why not just determine the run-time type when you - indirect, and avoid the special case? The contents don't matter - until you indirect anyway.) + the offset in target addressable memory units from the full object + to the pointed-to object -- that is, the value `embedded_offset' would + have if we followed the pointer and fetched the complete object. + (I don't really see the point. Why not just determine the + run-time type when you indirect, and avoid the special case? The + contents don't matter until you indirect anyway.) If we're not doing anything fancy, `enclosing_type' is equal to `type', and `embedded_offset' is zero, so everything works -- 2.30.2