From 37d3243dadc9c18a234d04716873b717efa93ae8 Mon Sep 17 00:00:00 2001 From: Andrew Pinski Date: Sat, 26 Nov 2005 22:18:04 +0000 Subject: [PATCH] re PR middle-end/23669 (fold does convert (-a)/10 into a/-10 with -fno-wrapv) 2005-11-26 Andrew Pinski PR middle-end/23669 * fold-const.c (fold_binary): Convert -A/-B to A/B for signed types when overflow is undefined. 2005-11-26 Andrew Pinski PR middle-end/23669 * gcc.dg/tree-ssa/divide-1.c: New test. * gcc.dg/tree-ssa/divide-2.c: New test. From-SVN: r107543 --- gcc/ChangeLog | 6 ++++++ gcc/fold-const.c | 13 +++++++++++++ gcc/testsuite/ChangeLog | 6 ++++++ gcc/testsuite/gcc.dg/tree-ssa/divide-1.c | 14 ++++++++++++++ gcc/testsuite/gcc.dg/tree-ssa/divide-2.c | 14 ++++++++++++++ 5 files changed, 53 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/divide-1.c create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/divide-2.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index f9b467d70fa..cc7b153f1de 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2005-11-26 Andrew Pinski + + PR middle-end/23669 + * fold-const.c (fold_binary): Convert -A/-B to A/B for signed types + when overflow is undefined. + 2005-11-26 Hans-Peter Nilsson * doc/md.texi (Insn Canonicalizations): Refer to the diff --git a/gcc/fold-const.c b/gcc/fold-const.c index 59037d59758..63f12949ab7 100644 --- a/gcc/fold-const.c +++ b/gcc/fold-const.c @@ -8440,6 +8440,19 @@ fold_binary (enum tree_code code, tree type, tree op0, tree op1) && TREE_INT_CST_HIGH (arg1) == -1) return fold_convert (type, negate_expr (arg0)); + /* Convert -A / -B to A / B when the type is signed and overflow is + undefined. */ + if (!TYPE_UNSIGNED (type) && !flag_wrapv + && TREE_CODE (arg0) == NEGATE_EXPR + && negate_expr_p (arg1)) + return fold_build2 (code, type, TREE_OPERAND (arg0, 0), + negate_expr (arg1)); + if (!TYPE_UNSIGNED (type) && !flag_wrapv + && TREE_CODE (arg1) == NEGATE_EXPR + && negate_expr_p (arg0)) + return fold_build2 (code, type, negate_expr (arg0), + TREE_OPERAND (arg1, 0)); + /* If arg0 is a multiple of arg1, then rewrite to the fastest div operation, EXACT_DIV_EXPR. diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 126a70d1b07..2cbcd6deef5 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2005-11-26 Andrew Pinski + + PR middle-end/23669 + * gcc.dg/tree-ssa/divide-1.c: New test. + * gcc.dg/tree-ssa/divide-2.c: New test. + 2005-11-26 Janne Blomqvist PR libgfortran/24945 diff --git a/gcc/testsuite/gcc.dg/tree-ssa/divide-1.c b/gcc/testsuite/gcc.dg/tree-ssa/divide-1.c new file mode 100644 index 00000000000..90acd8b7abc --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/divide-1.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-optimized" } */ + +int f(int a) +{ + return (-a)/10; +} + + +/* { dg-final { scan-tree-dump-times "-a / 10" 0 "optimized"} } */ +/* { dg-final { scan-tree-dump-times "a / -10" 1 "optimized"} } */ + +/* { dg-final { cleanup-tree-dump "optimized" } } */ + diff --git a/gcc/testsuite/gcc.dg/tree-ssa/divide-2.c b/gcc/testsuite/gcc.dg/tree-ssa/divide-2.c new file mode 100644 index 00000000000..5d719c02501 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/divide-2.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-options "-O1 -fdump-tree-optimized" } */ + +int f(int a) +{ + return 10/-a; +} + + +/* { dg-final { scan-tree-dump-times "10 / -a" 0 "optimized"} } */ +/* { dg-final { scan-tree-dump-times "-10 / a" 1 "optimized"} } */ + +/* { dg-final { cleanup-tree-dump "optimized" } } */ + -- 2.30.2