From 38dc8f35f92f9b0f7306eaa8ee26097b1e8f4d3f Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 10 Oct 2023 16:28:03 +0000 Subject: [PATCH] gdb: don't call so_list::clear in free_so I think this `so.clear ()` call is not useful. - so_list::clear deletes some things that now get automatically deleted when the so_list gets deleted right after in free_so. - so_list::clear resets some scalar fields of so_list, which we don't really care about since the so_list gets deleted right after. - so_list::clear calls target_so_ops::clear_so, of which there is a single implementation, svr4_clear_so. That implementation just resets a field in lm_info_svr4, which we don't care about, as it will get deleted when the so_list gets deleted right after. Change-Id: Ie4d72f2a04a4129e55c460bb5c69bc0af0d12b32 Approved-By: Pedro Alves Reviewed-By: Reviewed-By: Lancelot Six --- gdb/solib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/solib.c b/gdb/solib.c index b0ae9347f02..4594587a134 100644 --- a/gdb/solib.c +++ b/gdb/solib.c @@ -664,7 +664,6 @@ lm_info::~lm_info () = default; void free_so (so_list &so) { - so.clear (); delete &so; } -- 2.30.2