From 38de8abe21fe17c31888094bd860a84f88cb5749 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Wed, 12 Feb 2020 11:15:33 +0100 Subject: [PATCH] [gdb] Fix -Wstrict-null-sentinel warning (--with-iconv-bin) When using configure flag --with-iconv-bin=$(which iconv), we run into: ... gdb/charset.c: In function 'void find_charset_names()': gdb/charset.c:821:75: error: missing sentinel in function call [-Werror=format=] iconv_program = concat (iconv_dir.c_str(), SLASH_STRING, "iconv", NULL); ^ cc1plus: all warnings being treated as errors ... Fix the warning. Build and reg-tested on x86_64-linux. 2020-02-12 Lukas Durfina Tom de Vries * charset.c (find_charset_names): Cast concat NULL sentinel to char *. --- gdb/charset.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/charset.c b/gdb/charset.c index 5cfd2d80301..4e459c2b45d 100644 --- a/gdb/charset.c +++ b/gdb/charset.c @@ -818,7 +818,8 @@ find_charset_names (void) { std::string iconv_dir = relocate_gdb_directory (ICONV_BIN, ICONV_BIN_RELOCATABLE); - iconv_program = concat (iconv_dir.c_str(), SLASH_STRING, "iconv", NULL); + iconv_program + = concat (iconv_dir.c_str(), SLASH_STRING, "iconv", (char *) NULL); } #else iconv_program = xstrdup ("iconv"); -- 2.30.2