From 39ed5604d7bee498aa7cdd6a7bc9bf86df366fec Mon Sep 17 00:00:00 2001 From: Jan Kratochvil Date: Fri, 12 Apr 2013 16:04:07 +0000 Subject: [PATCH] gdb/ Fix GDB regression related to PR binutils/14813. * jit.c (mem_bfd_iovec_close): Return 0 for success. * minidebug.c (lzma_close): Add return value comment. * remote.c (remote_bfd_iovec_close): Return 0 for success. * solib-spu.c (spu_bfd_iovec_close): Likewise. * spu-linux-nat.c (spu_bfd_iovec_close): Likewise. --- gdb/ChangeLog | 11 ++++++++++- gdb/jit.c | 4 +++- gdb/minidebug.c | 2 ++ gdb/remote.c | 3 ++- gdb/solib-spu.c | 4 +++- gdb/spu-linux-nat.c | 4 +++- 6 files changed, 23 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index dc95da178ab..e99bd77d16b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,4 +1,13 @@ -2013-04-11 Jan Kratochvil +2013-04-12 Jan Kratochvil + + Fix GDB regression related to PR binutils/14813. + * jit.c (mem_bfd_iovec_close): Return 0 for success. + * minidebug.c (lzma_close): Add return value comment. + * remote.c (remote_bfd_iovec_close): Return 0 for success. + * solib-spu.c (spu_bfd_iovec_close): Likewise. + * spu-linux-nat.c (spu_bfd_iovec_close): Likewise. + +2013-04-12 Jan Kratochvil * config.in: Regenerate. diff --git a/gdb/jit.c b/gdb/jit.c index 33d3d612d06..6fc8524f54f 100644 --- a/gdb/jit.c +++ b/gdb/jit.c @@ -90,7 +90,9 @@ static int mem_bfd_iovec_close (struct bfd *abfd, void *stream) { xfree (stream); - return 1; + + /* Zero means success. */ + return 0; } /* For reading the file, we just need to pass through to target_read_memory and diff --git a/gdb/minidebug.c b/gdb/minidebug.c index 7b1463b74c9..a33628a18b6 100644 --- a/gdb/minidebug.c +++ b/gdb/minidebug.c @@ -226,6 +226,8 @@ lzma_close (struct bfd *nbfd, lzma_index_end (lstream->index, &gdb_lzma_allocator); xfree (lstream->data); xfree (lstream); + + /* Zero means success. */ return 0; } diff --git a/gdb/remote.c b/gdb/remote.c index f0dbba668cd..96abc5d09bf 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -9937,7 +9937,8 @@ remote_bfd_iovec_close (struct bfd *abfd, void *stream) connection was already torn down. */ remote_hostio_close (fd, &remote_errno); - return 1; + /* Zero means success. */ + return 0; } static file_ptr diff --git a/gdb/solib-spu.c b/gdb/solib-spu.c index 7be5232ed3c..fc9dcda72b8 100644 --- a/gdb/solib-spu.c +++ b/gdb/solib-spu.c @@ -286,7 +286,9 @@ static int spu_bfd_iovec_close (bfd *nbfd, void *stream) { xfree (stream); - return 1; + + /* Zero means success. */ + return 0; } static file_ptr diff --git a/gdb/spu-linux-nat.c b/gdb/spu-linux-nat.c index ca8d92d33ac..1fab9da37b6 100644 --- a/gdb/spu-linux-nat.c +++ b/gdb/spu-linux-nat.c @@ -277,7 +277,9 @@ static int spu_bfd_iovec_close (struct bfd *nbfd, void *stream) { xfree (stream); - return 1; + + /* Zero means success. */ + return 0; } static file_ptr -- 2.30.2