From 3a3508220eecf27e1952a73cd3ea6d6314ce8e1d Mon Sep 17 00:00:00 2001 From: Eli Zaretskii Date: Tue, 12 Mar 2019 19:47:23 +0200 Subject: [PATCH] Fix MinGW build with source-highlight gdb/ChangeLog 2019-03-12 Eli Zaretskii PR/24325 * source-cache.c: #undef open and close, to avoid unresolved externals during linking. --- gdb/ChangeLog | 6 ++++++ gdb/source-cache.c | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8d72d38cea4..4e592a38f40 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2019-03-12 Eli Zaretskii + + PR/24325 + * source-cache.c: #undef open and close, to avoid unresolved + externals during linking. + 2019-03-12 Tom Tromey * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now diff --git a/gdb/source-cache.c b/gdb/source-cache.c index 097c8a3ae12..435de2ac6ef 100644 --- a/gdb/source-cache.c +++ b/gdb/source-cache.c @@ -23,6 +23,12 @@ #include "cli/cli-style.h" #ifdef HAVE_SOURCE_HIGHLIGHT +/* If Gnulib redirects 'open' and 'close' to its replacements + 'rpl_open' and 'rpl_close' via cpp macros, including + below with those macros in effect will cause unresolved externals + when GDB is linked. Happens, e.g., in the MinGW build. */ +#undef open +#undef close #include #include #include -- 2.30.2