From 3b93626be9951b0f49f3e1609ddab53f86f712e1 Mon Sep 17 00:00:00 2001 From: Saagar Jha Date: Fri, 25 Sep 2020 00:05:24 -0700 Subject: [PATCH] Add a missing munmap_list move constructor compile_module attempts to request a move constructor, but because munmap_list doesn't have one it gets implicitly deleted. This is an warning on clang under -Wdefaulted-function-deleted (which is enabled by default): In file included from compile/compile-object-load.c:21: compile/compile-object-load.h:56:3: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] compile_module (compile_module &&other) = default; ^ compile/compile-object-load.h:86:22: note: move constructor of 'compile_module' is implicitly deleted because field 'munmap_list' has a deleted move constructor struct munmap_list munmap_list; ^ compile/compile-object-load.h:30:28: note: 'munmap_list' has been explicitly marked deleted here DISABLE_COPY_AND_ASSIGN (munmap_list); ^ gdb/ChangeLog: * compile/compile-object-load.h: Give munmap_list a move constructor. Change-Id: I300c52e27da70087f18c7e359773c2b984073d8b --- gdb/ChangeLog | 5 +++++ gdb/compile/compile-object-load.h | 1 + 2 files changed, 6 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 649131da999..57e46c48607 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-09-25 Saagar Jha + + * compile/compile-object-load.h (struct munmap_list): Add + explicitly-defined move constructor. + 2020-09-24 Tom Tromey PR tui/26638: diff --git a/gdb/compile/compile-object-load.h b/gdb/compile/compile-object-load.h index 0254390109e..166d442ad02 100644 --- a/gdb/compile/compile-object-load.h +++ b/gdb/compile/compile-object-load.h @@ -30,6 +30,7 @@ public: DISABLE_COPY_AND_ASSIGN (munmap_list); munmap_list &operator= (munmap_list &&) = default; + munmap_list (munmap_list &&) = default; /* Add a region to the list. */ void add (CORE_ADDR addr, CORE_ADDR size); -- 2.30.2