From 3c7066c1ed1b9f004813995d9a097a083a8bf4d0 Mon Sep 17 00:00:00 2001 From: Ian Romanick Date: Tue, 25 Aug 2015 17:44:00 +0100 Subject: [PATCH] nir: Silence unused parameter warnings in nir_constant_expression.c nir/nir_constant_expressions.c:290:25: warning: unused parameter 'num_components' [-Wunused-parameter] evaluate_ball3(unsigned num_components, nir_const_value *_src) ^ nir/nir_constant_expressions.c: In function 'evaluate_fddx': nir/nir_constant_expressions.c:1282:57: warning: unused parameter '_src' [-Wunused-parameter] evaluate_fddx(unsigned num_components, nir_const_value *_src) ^ v2: Unconditionally mark the parameters as MAYBE_UNUSED instead of conditionally adding (void) casts to keep the generator simple. Suggested by Jason. Number of total warnings in my build reduced from 1575 to 1485 (reduction of 89). Signed-off-by: Ian Romanick Reviewed-by: Kenneth Graunke --- src/compiler/nir/nir_constant_expressions.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_constant_expressions.py b/src/compiler/nir/nir_constant_expressions.py index 6b4d071236c..2cc106db794 100644 --- a/src/compiler/nir/nir_constant_expressions.py +++ b/src/compiler/nir/nir_constant_expressions.py @@ -267,8 +267,8 @@ struct bool32_vec { % for name, op in sorted(opcodes.iteritems()): static nir_const_value -evaluate_${name}(unsigned num_components, unsigned bit_size, - nir_const_value *_src) +evaluate_${name}(MAYBE_UNUSED unsigned num_components, unsigned bit_size, + MAYBE_UNUSED nir_const_value *_src) { nir_const_value _dst_val = { {0, } }; -- 2.30.2