From 3c915a2e84ff90117cf45461c7c6befd8bebb7a5 Mon Sep 17 00:00:00 2001 From: "Daniel R. Carvalho" Date: Wed, 19 Feb 2020 09:27:17 +0100 Subject: [PATCH] base: Make read-only functions const in ScalarBase These functions do not need to modify their storage's contents. ScalarBase's non-const value() has been removed. Change-Id: I4dd3899a29a741a7d8cd199ccd254b346d86ae07 Signed-off-by: Daniel R. Carvalho Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27084 Tested-by: kokoro Reviewed-by: Bobby R. Bruce Maintainer: Bobby R. Bruce --- src/base/statistics.hh | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/base/statistics.hh b/src/base/statistics.hh index 1c3d53df6..b1f27c726 100644 --- a/src/base/statistics.hh +++ b/src/base/statistics.hh @@ -522,13 +522,6 @@ class ScalarBase : public DataWrap this->setInit(); } - public: - /** - * Return the current value of this stat as its base type. - * @return The current value. - */ - Counter value() const { return data()->value(); } - public: ScalarBase(Group *parent = nullptr, const char *name = nullptr, const char *desc = nullptr) @@ -585,13 +578,17 @@ class ScalarBase : public DataWrap */ size_type size() const { return 1; } - Counter value() { return data()->value(); } + /** + * Return the current value of this stat as its base type. + * @return The current value. + */ + Counter value() const { return data()->value(); } - Result result() { return data()->result(); } + Result result() const { return data()->result(); } - Result total() { return result(); } + Result total() const { return result(); } - bool zero() { return result() == 0.0; } + bool zero() const { return result() == 0.0; } void reset() { data()->reset(this->info()); } void prepare() { data()->prepare(this->info()); } -- 2.30.2