From 3d149aff733692b368919191dc31e731cbba9cfa Mon Sep 17 00:00:00 2001
From: Dan Ravensloft <dan.ravensloft@gmail.com>
Date: Thu, 23 Apr 2020 00:56:49 +0100
Subject: [PATCH] intel_alm: work around a Quartus ICE

---
 techlibs/intel_alm/synth_intel_alm.cc | 10 ++++++++++
 tests/arch/intel_alm/quartus_ice.ys   | 12 ++++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 tests/arch/intel_alm/quartus_ice.ys

diff --git a/techlibs/intel_alm/synth_intel_alm.cc b/techlibs/intel_alm/synth_intel_alm.cc
index 47aa11500..5d4c78d74 100644
--- a/techlibs/intel_alm/synth_intel_alm.cc
+++ b/techlibs/intel_alm/synth_intel_alm.cc
@@ -200,6 +200,8 @@ struct SynthIntelALMPass : public ScriptPass {
 
 		if (check_label("map_ffs")) {
 			run("dff2dffe -direct-match $_DFF_*");
+			// As mentioned in common/dff_sim.v, Intel flops power up to zero,
+			// so use `zinit` to add inverters where needed.
 			run("zinit");
 			run("techmap -map +/techmap.v -map +/intel_alm/common/dff_map.v");
 			run("opt -full -undriven -mux_undef");
@@ -223,8 +225,16 @@ struct SynthIntelALMPass : public ScriptPass {
 
 		if (check_label("quartus")) {
 			if (quartus || help_mode) {
+				// Quartus ICEs if you have a wire which has `[]` in its name,
+				// which Yosys produces when building memories out of flops.
+				run("rename -hide w:*[* w:*]*");
+				// VQM mode does not support 'x, so replace those with zero.
 				run("setundef -zero");
+				// VQM mode does not support multi-bit constant assignments
+				// (e.g. 2'b00 is an error), so as a workaround use references
+				// to constant driver cells, which Quartus accepts.
 				run("hilomap -singleton -hicell __MISTRAL_VCC Q -locell __MISTRAL_GND Q");
+				// Rename from Yosys-internal MISTRAL_* cells to Quartus cells.
 				run("techmap -map +/intel_alm/common/quartus_rename.v");
 				run(stringf("techmap -map +/intel_alm/%s/quartus_rename.v", family_opt.c_str()));
 			}
diff --git a/tests/arch/intel_alm/quartus_ice.ys b/tests/arch/intel_alm/quartus_ice.ys
new file mode 100644
index 000000000..4b9b54d10
--- /dev/null
+++ b/tests/arch/intel_alm/quartus_ice.ys
@@ -0,0 +1,12 @@
+read_verilog <<EOT
+// Verilog has syntax for raw identifiers, where you start it with \ and end it with a space.
+// This test crashes Quartus due to it parsing \a[10] as a wire slice and not a raw identifier.
+module top();
+  (* keep *) wire [31:0] \a[10] ;
+  (* keep *) wire b;
+  assign b = \a[10] [31];
+endmodule
+EOT
+
+synth_intel_alm -family cyclonev -quartus
+select -assert-none w:*[* w:*]*
-- 
2.30.2