From 3d1df5554e0038c9e8ea95e86317355050a74cc6 Mon Sep 17 00:00:00 2001 From: Keith Whitwell Date: Tue, 14 Aug 2001 00:50:44 +0000 Subject: [PATCH] Compute first partials before taking cross product to calculate normal. Fixes diego santa cruz' nurbs lighting bug. --- src/mesa/tnl/t_imm_eval.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/tnl/t_imm_eval.c b/src/mesa/tnl/t_imm_eval.c index 1ae006666fd..6a69e9b3d86 100644 --- a/src/mesa/tnl/t_imm_eval.c +++ b/src/mesa/tnl/t_imm_eval.c @@ -1,4 +1,4 @@ -/* $Id: t_imm_eval.c,v 1.14 2001/08/01 05:10:42 keithw Exp $ */ +/* $Id: t_imm_eval.c,v 1.15 2001/08/14 00:50:44 keithw Exp $ */ /* * Mesa 3-D graphics library @@ -206,6 +206,14 @@ static void eval2_obj_norm( GLvector4f *obj_ptr, _math_de_casteljau_surf(map->Points, obj[i], du, dv, u, v, dimension, map->Uorder, map->Vorder); + du[0] = du[0]*obj[i][3] - du[3]*obj[i][0]; + du[1] = du[1]*obj[i][3] - du[3]*obj[i][1]; + du[2] = du[2]*obj[i][3] - du[3]*obj[i][2]; + + dv[0] = dv[0]*obj[i][3] - dv[3]*obj[i][0]; + dv[1] = dv[1]*obj[i][3] - dv[3]*obj[i][1]; + dv[2] = dv[2]*obj[i][3] - dv[3]*obj[i][2]; + CROSS3(normal[i], du, dv); NORMALIZE_3FV(normal[i]); } -- 2.30.2