From 3e11f04d4e09bf71d2e5899f0afa9d04e8f6196e Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Tue, 2 Jun 2020 14:21:30 -0700 Subject: [PATCH] turnip: Expose robustBufferAccess. It is a required device feature, and all enabled tests in dEQP-VK.robustness.* pass. Reviewed-by: Jonathan Marek Part-of: --- .gitlab-ci/deqp-freedreno-a630-fails.txt | 8 -------- src/freedreno/vulkan/tu_device.c | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/.gitlab-ci/deqp-freedreno-a630-fails.txt b/.gitlab-ci/deqp-freedreno-a630-fails.txt index 58f1576b50f..22ffe17093b 100644 --- a/.gitlab-ci/deqp-freedreno-a630-fails.txt +++ b/.gitlab-ci/deqp-freedreno-a630-fails.txt @@ -20,14 +20,6 @@ dEQP-VK.renderpass.suballocation.formats.d24_unorm_s8_uint.input.dont_care.dont_ dEQP-VK.renderpass.suballocation.formats.d24_unorm_s8_uint.input.load.dont_care.clear_draw_use_input_aspect_stencil_read_only dEQP-VK.renderpass.suballocation.multisample_resolve.layers_3.r16g16_snorm.samples_2 dEQP-VK.renderpass.suballocation.multisample_resolve.layers_3.r8g8b8a8_srgb.samples_4 -dEQP-VK.robustness.buffer_access.compute.scalar_copy.r32_sfloat.oob_storage_read.range_3_bytes -dEQP-VK.robustness.buffer_access.compute.vec4_copy.r32_uint.oob_storage_read.range_4_bytes -dEQP-VK.robustness.buffer_access.fragment.scalar_copy.out_of_alloc.oob_storage_read -dEQP-VK.robustness.buffer_access.fragment.vec4_copy.r32_sfloat.oob_uniform_read.range_4_bytes -dEQP-VK.robustness.buffer_access.vertex.texel_copy.r32g32b32a32_uint.oob_uniform_read.range_1_texel -dEQP-VK.robustness.buffer_access.vertex.vec4_copy.r32_sfloat.oob_storage_write.range_4_bytes -dEQP-VK.robustness.vertex_access.r32g32b32_sfloat.draw_indexed.triangle_out_of_bounds -dEQP-VK.robustness.vertex_access.r32_uint.draw_indexed.last_index_out_of_bounds dEQP-VK.synchronization.signal_order.shared_binary_semaphore.write_blit_image_read_blit_image.image_128_r32_uint_opaque_fd dEQP-VK.synchronization.signal_order.shared_binary_semaphore.write_blit_image_read_image_compute_indirect.image_128x128_r8_unorm_opaque_fd dEQP-VK.synchronization.signal_order.shared_binary_semaphore.write_copy_buffer_read_ssbo_fragment.buffer_262144_opaque_fd diff --git a/src/freedreno/vulkan/tu_device.c b/src/freedreno/vulkan/tu_device.c index c471117e5ed..467d56da5c4 100644 --- a/src/freedreno/vulkan/tu_device.c +++ b/src/freedreno/vulkan/tu_device.c @@ -581,7 +581,7 @@ tu_GetPhysicalDeviceFeatures(VkPhysicalDevice physicalDevice, memset(pFeatures, 0, sizeof(*pFeatures)); *pFeatures = (VkPhysicalDeviceFeatures) { - .robustBufferAccess = false, + .robustBufferAccess = true, .fullDrawIndexUint32 = true, .imageCubeArray = true, .independentBlend = true, -- 2.30.2