From 3ede8dd5f1096531a080bac6f17f2512bea7bbce Mon Sep 17 00:00:00 2001 From: Brian Paul Date: Mon, 20 Jan 2014 07:59:25 -0800 Subject: [PATCH] softpipe: fix crash when accessing null colorbuffer Fixes piglit fbo-missing-attachment-blit test. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73755 Reviewed-by: Roland Scheidegger --- src/gallium/drivers/softpipe/sp_quad_blend.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_quad_blend.c b/src/gallium/drivers/softpipe/sp_quad_blend.c index fb19ba52e8b..41149a06b63 100644 --- a/src/gallium/drivers/softpipe/sp_quad_blend.c +++ b/src/gallium/drivers/softpipe/sp_quad_blend.c @@ -1232,7 +1232,10 @@ choose_blend_quad(struct quad_stage *qs, softpipe->blend->rt[0].colormask == 0xf && softpipe->framebuffer.nr_cbufs == 1) { - if (!blend->rt[0].blend_enable) { + if (softpipe->framebuffer.cbufs[0] == NULL) { + qs->run = blend_noop; + } + else if (!blend->rt[0].blend_enable) { qs->run = single_output_color; } else if (blend->rt[0].rgb_src_factor == blend->rt[0].alpha_src_factor && -- 2.30.2