From 3f9bcf9136af794d44fa4b0802c0d4df6b170175 Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Tue, 11 Dec 2018 16:14:03 -0800 Subject: [PATCH] v3d: Make sure that a thrsw doesn't split a multop from its umul24. The thrsw will invalidate rtop, just like accumulators and flags. Caught by simulator assertions in CS imulextended/umulextended tests. Fixes: 90269ba35333 ("broadcom/vc5: Use THRSW to enable multi-threaded shaders.") --- src/broadcom/compiler/qpu_schedule.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/broadcom/compiler/qpu_schedule.c b/src/broadcom/compiler/qpu_schedule.c index 944059c9778..365aebdbd6d 100644 --- a/src/broadcom/compiler/qpu_schedule.c +++ b/src/broadcom/compiler/qpu_schedule.c @@ -405,6 +405,7 @@ calculate_deps(struct schedule_state *state, struct schedule_node *n) for (int i = 0; i < ARRAY_SIZE(state->last_r); i++) add_write_dep(state, &state->last_r[i], n); add_write_dep(state, &state->last_sf, n); + add_write_dep(state, &state->last_rtop, n); /* Scoreboard-locking operations have to stay after the last * thread switch. -- 2.30.2