From 3fd457c9ddd4b9f730e70bfd19b2f9eeeeaef089 Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Mon, 22 Jun 2015 16:32:06 -0700 Subject: [PATCH] i965/fs: Do the no16 perf logging directly in fs_visitor::no16() While we're at it, we'll drop the note about 10-20% performance loss. Reviewed-by: Kenneth Graunke Reviewed-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs.cpp | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 5d18dda4676..3b311ca4093 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp @@ -710,12 +710,7 @@ fs_visitor::no16(const char *msg) } else { simd16_unsupported = true; - if (brw->perf_debug) { - if (no16_msg) - ralloc_strcat(&no16_msg, msg); - else - no16_msg = ralloc_strdup(mem_ctx, msg); - } + perf_debug("SIMD16 shader failed to compile: %s", msg); } } @@ -4054,14 +4049,10 @@ brw_wm_fs_emit(struct brw_context *brw, /* Try a SIMD16 compile */ v2.import_uniforms(&v); if (!v2.run_fs()) { - perf_debug("SIMD16 shader failed to compile, falling back to " - "SIMD8 at a 10-20%% performance cost: %s", v2.fail_msg); + perf_debug("SIMD16 shader failed to compile: %s", v2.fail_msg); } else { simd16_cfg = v2.cfg; } - } else { - perf_debug("SIMD16 shader unsupported, falling back to " - "SIMD8 at a 10-20%% performance cost: %s", v.no16_msg); } } -- 2.30.2