From 3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sat, 22 Feb 2020 11:48:26 -0700 Subject: [PATCH] Fix latent display bug in tui_data_window tui_data_window creates new curses windows, but does not pass in coordinates relative to the data window's origin. This means that the data window could only ever be displayed as the topmost window in a layout. This is not a currently problem, because all the existing layouts do this; but a subsequent patch will add user-defined layouts, which could do otherwise. gdb/ChangeLog 2020-02-22 Tom Tromey * tui/tui-regs.c (tui_data_window::display_registers_from): Use correct coordinates. Change-Id: I5101f2b2869557b87381ebdeebd9b7fd28687831 --- gdb/ChangeLog | 5 +++++ gdb/tui/tui-regs.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 10a07df5d33..e35d5c5bc30 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-02-22 Tom Tromey + + * tui/tui-regs.c (tui_data_window::display_registers_from): Use + correct coordinates. + 2020-02-22 Tom Tromey * tui/tui-layout.h (tui_add_win_to_layout): Add comment. diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index bedf55cab8b..f0dfdefc80f 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -274,7 +274,7 @@ tui_data_window::display_registers_from (int start_element_no) { /* Create the window if necessary. */ m_regs_content[i].resize (1, item_win_width, - (item_win_width * j) + 1, cur_y); + x + (item_win_width * j) + 1, y + cur_y); i++; /* Next register. */ } cur_y++; /* Next row. */ -- 2.30.2