From 3ffaac206b7169712e1d556a881ea6730ea110a7 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Fri, 21 Nov 2014 08:15:04 +1030 Subject: [PATCH] PPC gold doesn't check for overflow properly * powerpc.cc (Target_powerpc::Relocate::relocate): Correct test for undefined weaks. --- gold/ChangeLog | 5 +++++ gold/powerpc.cc | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/gold/ChangeLog b/gold/ChangeLog index 14b764e4b24..66c7fca37b0 100644 --- a/gold/ChangeLog +++ b/gold/ChangeLog @@ -1,3 +1,8 @@ +2014-11-21 Alan Modra + + * powerpc.cc (Target_powerpc::Relocate::relocate): Correct test + for undefined weaks. + 2014-11-20 Alan Modra * powerpc.cc (Stub_control::Stub_control): Init stub14_group_size_ diff --git a/gold/powerpc.cc b/gold/powerpc.cc index 0442e56081f..4c90e389b85 100644 --- a/gold/powerpc.cc +++ b/gold/powerpc.cc @@ -7672,10 +7672,10 @@ Target_powerpc::Relocate::relocate( break; } if (status != Powerpc_relocate_functions::STATUS_OK - && !has_stub_value - && !(gsym != NULL - && gsym->is_weak_undefined() - && is_branch_reloc(r_type))) + && (has_stub_value + || !(gsym != NULL + && gsym->is_weak_undefined() + && is_branch_reloc(r_type)))) { gold_error_at_location(relinfo, relnum, rela.get_r_offset(), _("relocation overflow")); -- 2.30.2