From 403772ef6112b909826f8d7446fb4ceaf6f98a1e Mon Sep 17 00:00:00 2001 From: Christian Biesinger Date: Tue, 22 Oct 2019 14:58:45 -0500 Subject: [PATCH] Make demangled_name_entry::language not a bitfield Having it as a bitfield causes extra work, and this is not memory-sensitive. Furthermore, once https://sourceware.org/ml/gdb-patches/2019-10/msg00812.html lands, the bitfield won't even save any memory at all. gdb/ChangeLog: 2019-10-22 Christian Biesinger * symtab.c (struct demangled_name_entry) : Change from bitfield to regular variable. Change-Id: I4ea31d1cfcbe0f09a09bd058cd304862308dc388 --- gdb/ChangeLog | 5 +++++ gdb/symtab.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8255a8540c9..9cd38a3258b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-10-22 Christian Biesinger + + * symtab.c (struct demangled_name_entry) : Change from + bitfield to regular variable. + 2019-10-22 Christian Biesinger * symtab.c (struct demangled_name_entry): Add a constructor. diff --git a/gdb/symtab.c b/gdb/symtab.c index ed55cecc730..0a87fec764e 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -719,7 +719,7 @@ struct demangled_name_entry : mangled (mangled_name) {} gdb::string_view mangled; - ENUM_BITFIELD(language) language : LANGUAGE_BITS; + enum language language; char demangled[1]; }; -- 2.30.2