From 40d22035a7fc239ac1e944b75a2e3ee9029d1b76 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Tue, 26 May 2020 11:35:32 +0200 Subject: [PATCH] [gdb/testsuite] Add test-case gold-gdb-index.exp There's a PR binutils/15646 - "gold-generated .gdb_index has duplicated symbols that gdb-generated index doesn't", and gdb contains a workaround, added in commit 8943b87476 "Work around gold/15646". Add a test-case testing this workaround. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2020-05-26 Tom de Vries * gdb.base/gold-gdb-index-2.c: New test. * gdb.base/gold-gdb-index.c: New test. * gdb.base/gold-gdb-index.exp: New file. * gdb.base/gold-gdb-index.h: New test. --- gdb/testsuite/ChangeLog | 7 ++++ gdb/testsuite/gdb.base/gold-gdb-index-2.c | 23 +++++++++++ gdb/testsuite/gdb.base/gold-gdb-index.c | 29 ++++++++++++++ gdb/testsuite/gdb.base/gold-gdb-index.exp | 48 +++++++++++++++++++++++ gdb/testsuite/gdb.base/gold-gdb-index.h | 25 ++++++++++++ 5 files changed, 132 insertions(+) create mode 100644 gdb/testsuite/gdb.base/gold-gdb-index-2.c create mode 100644 gdb/testsuite/gdb.base/gold-gdb-index.c create mode 100644 gdb/testsuite/gdb.base/gold-gdb-index.exp create mode 100644 gdb/testsuite/gdb.base/gold-gdb-index.h diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index e4124bf3154..5c297306d2a 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2020-05-26 Tom de Vries + + * gdb.base/gold-gdb-index-2.c: New test. + * gdb.base/gold-gdb-index.c: New test. + * gdb.base/gold-gdb-index.exp: New file. + * gdb.base/gold-gdb-index.h: New test. + 2020-05-25 Tom de Vries * boards/gold-gdb-index.exp: New file. diff --git a/gdb/testsuite/gdb.base/gold-gdb-index-2.c b/gdb/testsuite/gdb.base/gold-gdb-index-2.c new file mode 100644 index 00000000000..2df637b5541 --- /dev/null +++ b/gdb/testsuite/gdb.base/gold-gdb-index-2.c @@ -0,0 +1,23 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2020 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include "gold-gdb-index.h" + +namespace N1 +{ + void bar () { C1::baz (); } +} diff --git a/gdb/testsuite/gdb.base/gold-gdb-index.c b/gdb/testsuite/gdb.base/gold-gdb-index.c new file mode 100644 index 00000000000..e0f8c2e4197 --- /dev/null +++ b/gdb/testsuite/gdb.base/gold-gdb-index.c @@ -0,0 +1,29 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2020 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include "gold-gdb-index.h" + +namespace N1 +{ + void foo () { C1::baz (); } +} + +int +main () +{ + return 0; +} diff --git a/gdb/testsuite/gdb.base/gold-gdb-index.exp b/gdb/testsuite/gdb.base/gold-gdb-index.exp new file mode 100644 index 00000000000..e42bf439dd5 --- /dev/null +++ b/gdb/testsuite/gdb.base/gold-gdb-index.exp @@ -0,0 +1,48 @@ +# Copyright 2020 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . */ + +# This tests the gdb workaround for PR binutils/15646. + +standard_testfile .c gold-gdb-index-2.c + +if {[prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" \ + {debug c++ additional_flags=-fuse-ld=gold \ + additional_flags=-Wl,--gdb-index \ + additional_flags=-ggnu-pubnames}]} { + return -1 +} + +if { [readnow] } { + return -1 +} + +gdb_test_no_output "set auto-solib-add off" + +if ![runto_main] then { + fail "can't run to main" + return 0 +} + +gdb_test_no_output "set breakpoint pending off" +gdb_test "break N1::misspelled" "Function \"N1::misspelled\" not defined\." + +gdb_test_multiple "maint info symtabs" "" { + -re -wrap "\{ symtab \[^\r\n\]*gold-gdb-index-2.c.*" { + fail $gdb_test_name + } + -re -wrap "" { + pass $gdb_test_name + } +} diff --git a/gdb/testsuite/gdb.base/gold-gdb-index.h b/gdb/testsuite/gdb.base/gold-gdb-index.h new file mode 100644 index 00000000000..81ebb7b16a5 --- /dev/null +++ b/gdb/testsuite/gdb.base/gold-gdb-index.h @@ -0,0 +1,25 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2020 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +namespace N1 +{ + class C1 + { + public: + static void baz () {} + }; +} -- 2.30.2