From 40e5240e1f32b1cc36c45551eb3f59253c40f317 Mon Sep 17 00:00:00 2001 From: "Maciej W. Rozycki" Date: Wed, 10 May 2017 19:03:15 +0100 Subject: [PATCH] MIPS/binutils/testsuite: Define names of temporary files Define `tempfile' and `copyfile' in `mips.exp' so that standalone script execution via `RUNTESTFLAGS=mips.exp' works rather than producing: Running .../binutils/testsuite/binutils-all/mips/mips.exp ... ERROR: tcl error sourcing .../binutils/testsuite/binutils-all/mips/mips.exp. ERROR: can't read "tempfile": no such variable while executing "binutils_assemble_flags ${srcfile} $tempfile $opts(as)" (procedure "run_dump_test" line 207) invoked from within "run_dump_test "mips-ase-1"" invoked from within "if [is_elf_format] { run_dump_test "mips-ase-1" run_dump_test "mips-ase-2" run_dump_test "mips-ase-3" run_dump_test "mixed-mips16" ..." (file ".../binutils/testsuite/binutils-all/mips/mips.exp" line 22) invoked from within "source .../binutils/testsuite/binutils-all/mips/mips.exp" ("uplevel" body line 1) invoked from within "uplevel #0 source .../binutils/testsuite/binutils-all/mips/mips.exp" invoked from within "catch "uplevel #0 source $test_file_name"" testcase .../binutils/testsuite/binutils-all/mips/mips.exp completed in 0 seconds binutils/ * testsuite/binutils-all/mips/mips.exp: Define `tempfile' and `copyfile' variables. --- binutils/ChangeLog | 5 +++++ binutils/testsuite/binutils-all/mips/mips.exp | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 4bf26f81bb4..e47d825798a 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,8 @@ +2017-05-10 Maciej W. Rozycki + + * testsuite/binutils-all/mips/mips.exp: Define `tempfile' and + `copyfile' variables. + 2017-05-10 Claudiu Zissulescu * readelf.c (decode_ARC_machine_flags): Recognize OSABI v4. diff --git a/binutils/testsuite/binutils-all/mips/mips.exp b/binutils/testsuite/binutils-all/mips/mips.exp index 672515c4e5a..33752c6ea31 100644 --- a/binutils/testsuite/binutils-all/mips/mips.exp +++ b/binutils/testsuite/binutils-all/mips/mips.exp @@ -19,6 +19,14 @@ if ![istarget mips*-*-*] { return } +if [is_remote host] { + set tempfile [remote_download host tmpdir/bintest.o] + set copyfile copy +} else { + set tempfile tmpdir/bintest.o + set copyfile tmpdir/copy +} + if [is_elf_format] { run_dump_test "mips-ase-1" run_dump_test "mips-ase-2" -- 2.30.2