From 41ab92a327c63bdf97edee356e46246f4ff306bc Mon Sep 17 00:00:00 2001 From: Jason Ekstrand Date: Fri, 7 Jun 2019 18:03:10 -0500 Subject: [PATCH] nir/gather_info: Move setting uses_64bit out of the switch Otherwise, as we add things to the switch, we're going to forget and add some 64-bit op at some point in the future and it'll stop getting flagged. There's no reason why we can't do the check for derivatives. Reviewed-by: Alyssa Rosenzweig Reviewed-by: Kenneth Graunke --- src/compiler/nir/nir_gather_info.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/compiler/nir/nir_gather_info.c b/src/compiler/nir/nir_gather_info.c index 04a1f9b38bc..51717cd6d7f 100644 --- a/src/compiler/nir/nir_gather_info.c +++ b/src/compiler/nir/nir_gather_info.c @@ -302,13 +302,14 @@ gather_alu_info(nir_alu_instr *instr, nir_shader *shader) shader->info.uses_fddx_fddy = true; break; default: - shader->info.uses_64bit |= instr->dest.dest.ssa.bit_size == 64; - unsigned num_srcs = nir_op_infos[instr->op].num_inputs; - for (unsigned i = 0; i < num_srcs; i++) { - shader->info.uses_64bit |= nir_src_bit_size(instr->src[i].src) == 64; - } break; } + + shader->info.uses_64bit |= instr->dest.dest.ssa.bit_size == 64; + unsigned num_srcs = nir_op_infos[instr->op].num_inputs; + for (unsigned i = 0; i < num_srcs; i++) { + shader->info.uses_64bit |= nir_src_bit_size(instr->src[i].src) == 64; + } } static void -- 2.30.2