From 425ea30f79e236c187430749be994309968e1dbd Mon Sep 17 00:00:00 2001 From: Dragan Mladjenovic Date: Wed, 13 Nov 2019 18:50:15 +0000 Subject: [PATCH] Sanitize the constant argument for rotr3 This was dormant for quite some time, but it started happening for me on gcc.c-torture/compile/pr65153.c sometime after r276645 for -mabi=32 linux runs. The pattern accepts any SMALL_OPERAND constant value while it asserts during the final that the value is in the mode size range. I this case it happens that combine_and_move_insns during ira makes a pattern with negative "shift count" which fails at final stage. This simple fix just truncates the constant operand to mode size the same as shift patterns. gcc/ChangeLog: 2019-11-13 Dragan Mladjenovic * config/mips/mips.md (rotr3): Sanitize the constant argument instead of asserting its value. From-SVN: r278152 --- gcc/ChangeLog | 5 +++++ gcc/config/mips/mips.md | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 004711204a8..3ffe1d7347f 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2019-11-13 Dragan Mladjenovic + + * config/mips/mips.md (rotr3): Sanitize the constant argument + instead of asserting its value. + 2019-11-13 Aldy Hernandez * gimple-fold.c (size_must_be_zero_p): Rewrite use of value_range diff --git a/gcc/config/mips/mips.md b/gcc/config/mips/mips.md index 658f5e62b84..4de97318e67 100644 --- a/gcc/config/mips/mips.md +++ b/gcc/config/mips/mips.md @@ -5845,8 +5845,8 @@ "ISA_HAS_ROR" { if (CONST_INT_P (operands[2])) - gcc_assert (INTVAL (operands[2]) >= 0 - && INTVAL (operands[2]) < GET_MODE_BITSIZE (mode)); + operands[2] = GEN_INT (INTVAL (operands[2]) + & (GET_MODE_BITSIZE (mode) - 1)); return "ror\t%0,%1,%2"; } -- 2.30.2