From 427e6a142188fcfdc0efd4eed41ae717ee233e94 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Wed, 11 Sep 2013 13:35:51 +0200 Subject: [PATCH] re PR middle-end/58385 (likely wrong code bug) PR tree-optimization/58385 * fold-const.c (build_range_check): If both low and high are NULL, use omit_one_operand_loc to preserve exp side-effects. * gcc.c-torture/execute/pr58385.c: New test. From-SVN: r202494 --- gcc/ChangeLog | 6 ++++++ gcc/fold-const.c | 2 +- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.c-torture/execute/pr58385.c | 21 +++++++++++++++++++ 4 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.c-torture/execute/pr58385.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 8b2e2bba301..e5e1702e954 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2013-09-11 Jakub Jelinek + + PR tree-optimization/58385 + * fold-const.c (build_range_check): If both low and high are NULL, + use omit_one_operand_loc to preserve exp side-effects. + 2013-09-11 Kyrylo Tkachov * config/arm/arm.md (arm_shiftsi3): New alternative l/l/M. diff --git a/gcc/fold-const.c b/gcc/fold-const.c index 9956b2c9f07..8d57928b95d 100644 --- a/gcc/fold-const.c +++ b/gcc/fold-const.c @@ -4299,7 +4299,7 @@ build_range_check (location_t loc, tree type, tree exp, int in_p, } if (low == 0 && high == 0) - return build_int_cst (type, 1); + return omit_one_operand_loc (loc, type, build_int_cst (type, 1), exp); if (low == 0) return fold_build2_loc (loc, LE_EXPR, type, exp, diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 718e5424a3f..c924967ed3b 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2013-09-11 Jakub Jelinek + + PR tree-optimization/58385 + * gcc.c-torture/execute/pr58385.c: New test. + 2013-09-11 Kyrylo Tkachov * gcc.target/arm/thumb-ifcvt-2.c: New test. diff --git a/gcc/testsuite/gcc.c-torture/execute/pr58385.c b/gcc/testsuite/gcc.c-torture/execute/pr58385.c new file mode 100644 index 00000000000..8d7da6fc972 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/pr58385.c @@ -0,0 +1,21 @@ +/* PR tree-optimization/58385 */ + +extern void abort (void); + +int a, b = 1; + +int +foo () +{ + b = 0; + return 0; +} + +int +main () +{ + ((0 || a) & foo () >= 0) <= 1 && 1; + if (b) + abort (); + return 0; +} -- 2.30.2